do not fail for no generator-config-path zk node #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -150,6 +150,20 @@ | |||
| expect(subject).to receive(:set_backends).with([],{}) | |||
| subject.send(:watcher_callback).call | |||
| end | |||
|
|
|||
| it 'does not crash if there is no zk node' do | |||
There was a problem hiding this comment.
the better way to do this is:
context "when there is no zk node" do
before :each do
expect(..)
end
...
it "does not crash" do
...
end
end
This test is also very similar and has a lot of shared expect calls with the previous test (it also raises a ZK::Exceptions::NoNode but for path instead of generator_config_path) so maybe we can clean that up a bit (ex: put generator_config_path in a let(..) statement)
melaniecebula
approved these changes
Oct 1, 2018
jiancheung
force-pushed
the
jian_cheung--handle-no-node-for-generator-config-path
branch
from
d95b2af
to
6a7e367
Compare
|
|
||
| context "when generator_config_path is disabled" do | ||
| let(:discovery) { { 'method' => 'zookeeper', 'hosts' => 'somehost', 'path' => 'some/path', 'generator_config_path' => 'disabled' } } | ||
| context 'generator_config_path is defined' do |
There was a problem hiding this comment.
nit : context blocks generally start with a when ... statement
jiancheung
force-pushed
the
jian_cheung--handle-no-node-for-generator-config-path
branch
from
6a7e367
to
f84fd6e
Compare
jiancheung
deleted the
jian_cheung--handle-no-node-for-generator-config-path
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if
generator_config_pathis pointed to a non-existent zk node, synapse will crash.Let's fail more gracefully and use the default behavior of
new_config_for_generator = {}.@bsherrod @reissbaker
cc @juchem @lap1817 (common contributors)