Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project: rename vx => visx #803

Merged
merged 74 commits into from
Sep 20, 2020
Merged

project: rename vx => visx #803

merged 74 commits into from
Sep 20, 2020

Conversation

williaster
Copy link
Collaborator

@williaster williaster commented Sep 18, 2020

🏠 Internal

This PR makes the following updates throughout the entire monorepo for the project rename as described in #802:

  • [package.json]
    • updates package names, keywords, and (dev/peer)dependencies from @vx/* => @visx/* (and @vx/vx => @visx/visx)
    • updates github.com/hshoff/vx => github.com/airbnb/visx
  • updates CI references from vx => visx where needed
  • updates all packages/vx-* directory names to packages/visx-* (and vx-vx => visx/visx)
  • updates all vx references in code + READMEs to visx e.g.,
    • import * from '@vx/* => import * from '@visx/*
    • className="vx-*" => className="visx-*
    • npm package badges
  • [demo]
    • updates all sandbox package.jsons as described above
    • updates all sandbox directories sandboxes/vx-* => sandboxes/visx-*
    • updates variable/type names like VxPackages => VisxPackages
  • updates all instances of vx-demo.now.sh/* => airbnb.io/visx/* where the new demo site will live
  • updates the contributors of the root package.json to me, @hshoff, and @kristw who are currently the most active airbnb contributors

All filename changes were made with git mv to preserve history as much as possible. It looks like the web UI is calling some of these new files, but the commits locally showed renames so it may be better than it looks here 🤞 .

💥 Breaking Changes

  • [all packages] vx-... classNames are renamed to visx-...
  • [demo] existing codesandbox links (code that generates these is updated, I mean those referenced in PRs etc.) which reference vx-demo directory structure will break (example). These can be converted by doing something like the following:
    • github/hshoff/vx/tree/master/packages/vx-demo/src/sandboxes/vx-pack (before)
    • github/airbnb/visx/tree/master/packages/visx-demo/src/sandboxes/visx-pack (after)
  • [tooltip] className="vx-tooltip-portal" => visx-tooltip (so as not to be confused with the new TooltipInPortal)

Testing

  • CI
    • locally
    • PR
  • demo site works
  • test publishing @visx/*

@hshoff @kristw

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
packages/visx-demo/public/static/docs/visx-demo.html Outdated Show resolved Hide resolved
packages/visx-demo/public/static/docs/visx-demo.html Outdated Show resolved Hide resolved
packages/visx-demo/public/static/docs/visx-demo.html Outdated Show resolved Hide resolved
@williaster williaster merged commit 0cd702a into master Sep 20, 2020
@williaster williaster deleted the chris--rename-ii branch September 20, 2020 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants