Incomplete airbrake:heroku:add_deploy_notification rake task #168

Closed
dukedave opened this Issue Jan 9, 2013 · 6 comments

Comments

Projects
None yet
2 participants
@dukedave

dukedave commented Jan 9, 2013

None of the:

  • deploy[local_username]
  • deploy[scm_revision]
  • deploy[scm_repository]

parameters are included in the hook URL, yet an example for using all with Heroku is given on the Airbrake docs site (under the Heroku DeployHooks section).

@ghost ghost assigned shime Jan 10, 2013

@shime

This comment has been minimized.

Show comment Hide comment
@shime

shime Jan 20, 2013

Contributor

All seems to be working for me. Can you give me the failing example?

Contributor

shime commented Jan 20, 2013

All seems to be working for me. Can you give me the failing example?

@dukedave

This comment has been minimized.

Show comment Hide comment
@dukedave

dukedave Jan 20, 2013

Sure. This issue is that some (optional) parameters which are supported by Airbrake's deploy notification push URL are available in the the task, but aren't added to the URL (i.e. they aren't assigned to command).

If you look at the bottom of the Airbrake docs link above you'll see this snippet:

&deploy[local_username]={{user}}\
&deploy[scm_revision]={{head_long}}\
&deploy[scm_repository]=GITHUB_URL" # e.g. git@github.com:username/repo.git

I suggest that these could be added to the task on this line:

command << "&deploy[rails_env]=#{heroku_rails_env}" if heroku_rails_env

Sure. This issue is that some (optional) parameters which are supported by Airbrake's deploy notification push URL are available in the the task, but aren't added to the URL (i.e. they aren't assigned to command).

If you look at the bottom of the Airbrake docs link above you'll see this snippet:

&deploy[local_username]={{user}}\
&deploy[scm_revision]={{head_long}}\
&deploy[scm_repository]=GITHUB_URL" # e.g. git@github.com:username/repo.git

I suggest that these could be added to the task on this line:

command << "&deploy[rails_env]=#{heroku_rails_env}" if heroku_rails_env
@shime

This comment has been minimized.

Show comment Hide comment
@shime

shime Jan 20, 2013

Contributor

Great explanation!

👍

Contributor

shime commented Jan 20, 2013

Great explanation!

👍

@shime shime closed this Jan 20, 2013

@dukedave

This comment has been minimized.

Show comment Hide comment
@dukedave

dukedave Jan 21, 2013

Oh, I don't think it was such a good explanation!

These params should be set by the Heroku deployhooks:http add-on, like this:

deploy[local_username]={{user}}
deploy[scm_revision]={{head_long}}

This one is a little more awkward:

deploy[scm_repository]=`git config --get remote.origin.url`

Oh, I don't think it was such a good explanation!

These params should be set by the Heroku deployhooks:http add-on, like this:

deploy[local_username]={{user}}
deploy[scm_revision]={{head_long}}

This one is a little more awkward:

deploy[scm_repository]=`git config --get remote.origin.url`
@shime

This comment has been minimized.

Show comment Hide comment
@shime

shime Jan 21, 2013

Contributor

@dukedave thanks once again! This should be it.

Contributor

shime commented Jan 21, 2013

@dukedave thanks once again! This should be it.

@dukedave

This comment has been minimized.

Show comment Hide comment
@dukedave

dukedave Jan 21, 2013

👍

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment