New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
failure with Airbrake takes down entire app #23
Comments
Hi Skippy, We are in the process of moving to http://www.airbrake.io and we have added a new SSL certificate. Can you update the sender test to https://airbrake.io on line 114 & 130. Can you test this and let me know if your still seeing this issue? |
still failing: https://gist.github.com/1299824 this is a slightly unrelated item though; the way the airbrake code is currently structured, if anything happens it can take down the entire host site, or delay it by up to 5 seconds. That is the issue I'm hoping to raise in this ticket. thanks! |
hey @airbrakeben, so now that #17 is on its way to being resolved, what do you think about this one? I think there are three levels of fixes, and at least one of them should be done to increase robustness:
thoughts? |
I like the method-level catch-all rescue as a first&easy way to counter this. Am curious about your threaded posting solution. Do you mind sharing a gist of your implementation? Would like to run some benchmarks and see what the mem/cpu impact would be for a few scenarios. Thanks! |
Reorganizes unit tests in contexts Airbrake#setup_http_connection rescues exceptions, logs them and re-raises Airbrake#send_to_airbrake rescues exceptions, logs and swallows (returns nil). Fixes issue #23
related to: #17
when the SSL misconfiguration error is thrown for that hoptoad, it bubbles up the exception. We use hoptoad in a lot of cases to notify us when something happened but we then swallow the error and continue on...and right now it is brining things to a sudden halt.
The SSL misconfiguration issue aside, this concerns me because it means the app is dependent upon a 3rd party system to function; this isn't fire and forget but fire and hope Airbrake doesn't fail or take 5 seconds to return. I would be very interested in working with you all to convert this over to a separate thread that doesn't get in the way of the application. If you are open to that let me know!
thanks
The text was updated successfully, but these errors were encountered: