Idea: ensure rake integration is enabled when rescue_rake_exceptions is true #292
Comments
Either approach seems like it might be acceptable. |
I think option 1. is the best. It's less intrusive and less complicated. I'll keep an eye out for your PR. |
Nitrodist
added a commit
to Nitrodist/airbrake
that referenced
this issue
May 16, 2014
An LoadError exception is now raised when the client is configured to rescue from rake exceptions and airbrake/rake_handler has not been loaded. Fixes airbrake#292
It lives. #294 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I ran into a bit of an issue where I thought I had enabled the rake integration in my ruby project but it turns out that airbrake wasn't sending the exceptions to airbrake (even though I had
airbrake
required andrescue_rake_exceptions
was set true).As it turns out (and in the cucumber spec), one must require
airbrake/rake_handler
for it to work. Without this required, then the exceptions won't be sent to Airbrake (silently not sending).Given the nature of rake tasks, I think that if the setting for rescuing from rake exceptions is set to true, then we should ensure that the rake integration is enabled via one or two ways:
airbrake/rake_handler
isn't loaded whenrescue_rake_exceptions
is set to trueairbrake/rake_handler
afterrescue_rake_exceptions
is enabled.I'm willing to do the work to get this going, but I'd like to know which one is the appropriate way to do it before working on it.
The text was updated successfully, but these errors were encountered: