Skip to content

builder method to_xs breaks when using 1.8.7 #32

Closed
elisehuard opened this Issue Nov 11, 2011 · 7 comments

6 participants

@elisehuard

I submitted a pull request to jimweirich's builder (3.0.0), but in the meantime the bug causes the airbrake gem to break in 1.8.7
[2011-11-11 11:14:49] ERROR ArgumentError: wrong number of arguments (1 for 0)
691 /Users/elise/.rvm/gems/ruby-1.8.7-p352@ppi/gems/builder-3.0.0/lib/builder/xmlbase.rb:135:in to_xs'
692 /Users/elise/.rvm/gems/ruby-1.8.7-p352@ppi/gems/builder-3.0.0/lib/builder/xmlbase.rb:135:in
_escape'
693 /Users/elise/.rvm/gems/ruby-1.8.7-p352@ppi/gems/builder-3.0.0/lib/builder/xmlbase.rb:140:in _escape_quote'
694 /Users/elise/.rvm/gems/ruby-1.8.7-p352@ppi/gems/builder-3.0.0/lib/builder/xmlmarkup.rb:320:in
_attr_value'
695 /Users/elise/.rvm/gems/ruby-1.8.7-p352@ppi/gems/builder-3.0.0/lib/builder/xmlmarkup.rb:308:in _insert_attributes'
696 /Users/elise/.rvm/gems/ruby-1.8.7-p352@ppi/gems/builder-3.0.0/lib/builder/xmlmarkup.rb:306:in
each'
697 /Users/elise/.rvm/gems/ruby-1.8.7-p352@ppi/gems/builder-3.0.0/lib/builder/xmlmarkup.rb:306:in _insert_attributes'
698 /Users/elise/.rvm/gems/ruby-1.8.7-p352@ppi/gems/builder-3.0.0/lib/builder/xmlmarkup.rb:284:in
_special'
699 /Users/elise/.rvm/gems/ruby-1.8.7-p352@ppi/gems/builder-3.0.0/lib/builder/xmlmarkup.rb:250:in instruct!'
700 /Users/elise/.rvm/gems/ruby-1.8.7-p352@ppi/gems/airbrake-3.0.5/lib/airbrake/notice.rb:113:in
to_xml'

Hopefully this fix will be pulled in soon, if you could then update your dependencies that would be great.

@DriesS
DriesS commented Nov 18, 2011

+1

@thbar
thbar commented Dec 9, 2011

+1

@thbar
thbar commented Dec 9, 2011

In case someone else needs this: here's the fix from @elisehuard

elisehuard/builder@53582a8

@kaorukobo

+1

@kaorukobo

...Hm, this problem does not seem to be one around ruby's version. ActiveSupport 3.1.3 maps fast_xs(in hpricot) to to_xs() when fast_xs is already installed. But fast_xs does not accept an argument, so it cause this error.
(my env: Ruby 1.8.7 + ActiveSupport 3.1.3)

@elisehuard

yes, see the thread around the builder issue: this should be fixed under newer versions of activesupport
jimweirich/builder#12

@brauliobo

+1

@shime shime closed this May 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.