Add the ability to pass XML directly to send_to_airbrake #124

Merged
merged 1 commit into from Sep 13, 2012

Conversation

Projects
None yet
2 participants
@zanker
Contributor

zanker commented Sep 13, 2012

Currently you have to serialize the data, pass it to Resque, unserialize it, pass it to send_to_airbrake, which then immediately serializes it again as XML.

Letting people serialize it to XML ahead of time simplifies setting up async reporting and reduces the chance that another error will occur when trying to send a report about the original error.

The only real difference is that if you pass XML, it will now dump XML if Airbrake gets an HTTP error from sending the request, it will dump the XML rather than pretty printed.

@zanker zanker closed this Sep 13, 2012

@zanker zanker reopened this Sep 13, 2012

shime added a commit that referenced this pull request Sep 13, 2012

Merge pull request #124 from zanker/send-xml
Add the ability to pass XML directly to send_to_airbrake

@shime shime merged commit fa6c1ff into airbrake:master Sep 13, 2012

@shime

This comment has been minimized.

Show comment
Hide comment
@shime

shime Sep 13, 2012

Contributor

❤️ Thanks for this. Yeah, on failure it will print the XML passed.

Contributor

shime commented Sep 13, 2012

❤️ Thanks for this. Yeah, on failure it will print the XML passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment