Ensure rake integration is enabled when rescue_rake_exceptions is true#294
Merged
alif merged 1 commit intoairbrake:masterfrom May 20, 2014
Merged
Conversation
An LoadError exception is now raised when the client is configured to rescue from rake exceptions and airbrake/rake_handler has not been loaded. Fixes airbrake#292
Contributor
|
Can you confirm that cucumber tests pass? I ask this because many times people don't think to run them locally. |
Contributor
Author
|
Works for me: ~/airbrake <ensure-rake-integration> be rake cucumber
/Users/mcampbell/.rbenv/versions/2.0.0-p0/bin/ruby -S bundle exec cucumber --tags ~@wip features/rake.feature
Feature: Use the Gem to catch errors in a Rake application
Background: # features/rake.feature:3
Given I've prepared the Rakefile # features/step_definitions/rake_steps.rb:1
Scenario: Ignoring exceptions # features/rake.feature:6
When I run rake with airbrake ignored # features/step_definitions/rake_steps.rb:7
Then Airbrake should not catch the exception # features/step_definitions/rake_steps.rb:12
Scenario: Catching exceptions in Rake # features/rake.feature:10
When I run rake with airbrake # features/step_definitions/rake_steps.rb:7
Then Airbrake should catch the exception # features/step_definitions/rake_steps.rb:16
Scenario: Falling back to default handler before Airbrake is configured # features/rake.feature:14
When I run rake with airbrake not yet configured # features/step_definitions/rake_steps.rb:7
Then Airbrake should not catch the exception # features/step_definitions/rake_steps.rb:12
Scenario: Disabling Rake exception catcher # features/rake.feature:18
When I run rake with airbrake disabled # features/step_definitions/rake_steps.rb:7
Then Airbrake should not catch the exception # features/step_definitions/rake_steps.rb:12
Scenario: Autodetect, running from terminal # features/rake.feature:22
When I run rake with airbrake autodetect from terminal # features/step_definitions/rake_steps.rb:7
Then Airbrake should not catch the exception # features/step_definitions/rake_steps.rb:12
Scenario: Autodetect, not running from terminal # features/rake.feature:26
When I run rake with airbrake autodetect not from terminal # features/step_definitions/rake_steps.rb:7
Then Airbrake should catch the exception # features/step_definitions/rake_steps.rb:16
6 scenarios (6 passed)
18 steps (18 passed)
0m30.083s |
alif
added a commit
that referenced
this pull request
May 20, 2014
Ensure rake integration is enabled when rescue_rake_exceptions is true
Contributor
Author
|
@alif the command only did it for that one feature thing, though... not sure how to get the rest of the features to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An LoadError exception is now raised when the client is configured to
rescue from rake exceptions and airbrake/rake_handler has not been
loaded.
Fixes #292