Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure rake integration is enabled when rescue_rake_exceptions is true #294

Merged
merged 1 commit into from May 20, 2014

Conversation

Projects
None yet
2 participants
@Nitrodist
Copy link
Contributor

commented May 16, 2014

An LoadError exception is now raised when the client is configured to
rescue from rake exceptions and airbrake/rake_handler has not been
loaded.

Fixes #292

Ensure rake integration is enabled when rescue_rake_exceptions is true
An LoadError exception is now raised when the client is configured to
rescue from rake exceptions and airbrake/rake_handler has not been
loaded.

Fixes #292
@alif

This comment has been minimized.

Copy link
Contributor

commented May 20, 2014

Can you confirm that cucumber tests pass? I ask this because many times people don't think to run them locally.

@Nitrodist

This comment has been minimized.

Copy link
Contributor Author

commented May 20, 2014

Works for me:

 ~/airbrake <ensure-rake-integration> be rake cucumber
/Users/mcampbell/.rbenv/versions/2.0.0-p0/bin/ruby -S bundle exec cucumber --tags ~@wip features/rake.feature
Feature: Use the Gem to catch errors in a Rake application

  Background:                        # features/rake.feature:3
    Given I've prepared the Rakefile # features/step_definitions/rake_steps.rb:1

  Scenario: Ignoring exceptions                  # features/rake.feature:6
    When I run rake with airbrake ignored        # features/step_definitions/rake_steps.rb:7
    Then Airbrake should not catch the exception # features/step_definitions/rake_steps.rb:12

  Scenario: Catching exceptions in Rake      # features/rake.feature:10
    When I run rake with airbrake            # features/step_definitions/rake_steps.rb:7
    Then Airbrake should catch the exception # features/step_definitions/rake_steps.rb:16

  Scenario: Falling back to default handler before Airbrake is configured # features/rake.feature:14
    When I run rake with airbrake not yet configured                      # features/step_definitions/rake_steps.rb:7
    Then Airbrake should not catch the exception                          # features/step_definitions/rake_steps.rb:12

  Scenario: Disabling Rake exception catcher     # features/rake.feature:18
    When I run rake with airbrake disabled       # features/step_definitions/rake_steps.rb:7
    Then Airbrake should not catch the exception # features/step_definitions/rake_steps.rb:12

  Scenario: Autodetect, running from terminal              # features/rake.feature:22
    When I run rake with airbrake autodetect from terminal # features/step_definitions/rake_steps.rb:7
    Then Airbrake should not catch the exception           # features/step_definitions/rake_steps.rb:12

  Scenario: Autodetect, not running from terminal              # features/rake.feature:26
    When I run rake with airbrake autodetect not from terminal # features/step_definitions/rake_steps.rb:7
    Then Airbrake should catch the exception                   # features/step_definitions/rake_steps.rb:16

6 scenarios (6 passed)
18 steps (18 passed)
0m30.083s

alif added a commit that referenced this pull request May 20, 2014

Merge pull request #294 from Nitrodist/ensure-rake-integration
Ensure rake integration is enabled when rescue_rake_exceptions is true

@alif alif merged commit 32c35fe into airbrake:master May 20, 2014

@Nitrodist

This comment has been minimized.

Copy link
Contributor Author

commented May 20, 2014

@alif the command only did it for that one feature thing, though... not sure how to get the rest of the features to run.

@Nitrodist Nitrodist deleted the Nitrodist:ensure-rake-integration branch May 20, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.