railtie: insert our Rails middleware before Rails' one #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyrylo
force-pushed
the
401-track-error-four-o-four
branch
from
660d8cf
to
985d1ef
Compare
Fixes #401 (Track 404 with airbrake) > The ActionDispatch::ShowExceptions middleware rescues any exception > returned by the application and renders nice exception pages if the > request is local or if config.consider_all_requests_local is set to > true. If config.action_dispatch.show_exceptions is set to false, > exceptions will be raised regardless. Changing the order of middleware allows us to rescue the exception coming from the Rails middleware. Please note that [we still ignore some exceptions][1] such as ActionController::RoutingError, which we are able to catch now. [1]: https://github.com/airbrake/airbrake/blob/02d29ccde1c46f957c9cf8261835ec7f9386e041/lib/airbrake/configuration.rb#L146
kyrylo
force-pushed
the
401-track-error-four-o-four
branch
from
985d1ef
to
5645549
Compare
|
This is broken. Needs more investigation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #401 (Track 404 with airbrake)
Changing the order of middleware allows us to rescue the exception
coming from the Rails middleware. Please note that we still ignore some
exceptions such as ActionController::RoutingError, which we are able
to catch now.