Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Critical] All app secrets stored in environment variables are passed to airbrake #51

Closed
ProGM opened this Issue Mar 10, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@ProGM
Copy link

commented Mar 10, 2017

I'm using phpbrake in my php app deployed on heroku.

As good practice, heroku suggests to store all app secrets in environment variables.

I noticed that phpbrake is sending the entire content of the $_SERVER variable in its report, indeed passing all app secrets.

https://github.com/airbrake/phpbrake/blob/master/src/Notifier.php#L148

Heroku documentation states:

Any config var you set on your Heroku application will be available at runtime using getenv() or in $_ENV/$_SERVER. We will use this mechanism to dynamically read the AWS security keys (key ID and secret key) and the S3 bucket name in our code; all you need to do is set these three bits information.

https://devcenter.heroku.com/articles/s3-upload-php#setting-application-config-vars

I think this is really bad and pretty critical and should be fixed in some way. However I'm not sure you or heroku should deal with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.