From 41f6b351537b9970b0e13c57104a9bf487682d83 Mon Sep 17 00:00:00 2001 From: Rodi Reich Zilberman <867491+rodireich@users.noreply.github.com> Date: Mon, 20 May 2024 19:05:50 -0700 Subject: [PATCH] fix tests --- .../jdbc/test/JdbcSourceAcceptanceTest.kt | 28 ++++++++++++++++--- 1 file changed, 24 insertions(+), 4 deletions(-) diff --git a/airbyte-cdk/java/airbyte-cdk/db-sources/src/testFixtures/kotlin/io/airbyte/cdk/integrations/source/jdbc/test/JdbcSourceAcceptanceTest.kt b/airbyte-cdk/java/airbyte-cdk/db-sources/src/testFixtures/kotlin/io/airbyte/cdk/integrations/source/jdbc/test/JdbcSourceAcceptanceTest.kt index 611e999bb84f..239ec8c9a5c4 100644 --- a/airbyte-cdk/java/airbyte-cdk/db-sources/src/testFixtures/kotlin/io/airbyte/cdk/integrations/source/jdbc/test/JdbcSourceAcceptanceTest.kt +++ b/airbyte-cdk/java/airbyte-cdk/db-sources/src/testFixtures/kotlin/io/airbyte/cdk/integrations/source/jdbc/test/JdbcSourceAcceptanceTest.kt @@ -421,13 +421,24 @@ abstract class JdbcSourceAcceptanceTest> { setEmittedAtToNull(actualMessages) - val expectedMessages = airbyteMessagesReadOneColumn + val expectedMessages: MutableList = airbyteMessagesReadOneColumn + + expectedMessages.addFirst(AirbyteTraceMessageUtility.makeStreamStatusTraceAirbyteMessage( + AirbyteStreamStatusHolder(AirbyteStreamNameNamespacePair(streamName(), defaultNamespace), AirbyteStreamStatusTraceMessage.AirbyteStreamStatus.STARTED) + )) + + expectedMessages.addLast(AirbyteTraceMessageUtility.makeStreamStatusTraceAirbyteMessage( + AirbyteStreamStatusHolder(AirbyteStreamNameNamespacePair(streamName(), defaultNamespace), AirbyteStreamStatusTraceMessage.AirbyteStreamStatus.COMPLETE) + )) + setTraceEmittedAtToNull(actualMessages) + setTraceEmittedAtToNull(expectedMessages) + Assertions.assertEquals(expectedMessages.size, actualMessages.size) Assertions.assertTrue(expectedMessages.containsAll(actualMessages)) Assertions.assertTrue(actualMessages.containsAll(expectedMessages)) } - protected open val airbyteMessagesReadOneColumn: List + protected open val airbyteMessagesReadOneColumn: MutableList get() { val expectedMessages = testMessages @@ -765,10 +776,19 @@ abstract class JdbcSourceAcceptanceTest> { .count() .toInt(), ) - val expectedMessages = getExpectedAirbyteMessagesSecondSync(namespace) + val expectedMessages: MutableList = getExpectedAirbyteMessagesSecondSync(namespace) setEmittedAtToNull(actualMessagesSecondSync) + expectedMessages.addFirst(AirbyteTraceMessageUtility.makeStreamStatusTraceAirbyteMessage( + AirbyteStreamStatusHolder(AirbyteStreamNameNamespacePair(configuredCatalog.streams[0].stream.name, defaultNamespace), AirbyteStreamStatusTraceMessage.AirbyteStreamStatus.STARTED) + )) + + expectedMessages.addLast(AirbyteTraceMessageUtility.makeStreamStatusTraceAirbyteMessage( + AirbyteStreamStatusHolder(AirbyteStreamNameNamespacePair(configuredCatalog.streams[0].stream.name, defaultNamespace), AirbyteStreamStatusTraceMessage.AirbyteStreamStatus.COMPLETE) + )) + setTraceEmittedAtToNull(actualMessagesSecondSync) + setTraceEmittedAtToNull(expectedMessages) Assertions.assertEquals(expectedMessages.size, actualMessagesSecondSync.size) Assertions.assertTrue(expectedMessages.containsAll(actualMessagesSecondSync)) Assertions.assertTrue(actualMessagesSecondSync.containsAll(expectedMessages)) @@ -788,7 +808,7 @@ abstract class JdbcSourceAcceptanceTest> { protected open fun getExpectedAirbyteMessagesSecondSync( namespace: String? - ): List { + ): MutableList { val expectedMessages: MutableList = ArrayList() expectedMessages.add( AirbyteMessage()