diff --git a/airbyte-webapp/src/components/destination/DestinationForm/DestinationForm.tsx b/airbyte-webapp/src/components/destination/DestinationForm/DestinationForm.tsx index 7a47baafbbed..e5979698ab07 100644 --- a/airbyte-webapp/src/components/destination/DestinationForm/DestinationForm.tsx +++ b/airbyte-webapp/src/components/destination/DestinationForm/DestinationForm.tsx @@ -20,7 +20,7 @@ interface DestinationFormProps { serviceType: string; destinationDefinitionId?: string; connectionConfiguration?: ConnectionConfiguration; - }) => void; + }) => Promise; destinationDefinitions: DestinationDefinitionRead[]; hasSuccess?: boolean; error?: FormError | null; diff --git a/airbyte-webapp/src/pages/SourcesPage/pages/CreateSourcePage/components/SourceForm.tsx b/airbyte-webapp/src/pages/SourcesPage/pages/CreateSourcePage/components/SourceForm.tsx index 4a4962912253..3a36bd080e36 100644 --- a/airbyte-webapp/src/pages/SourcesPage/pages/CreateSourcePage/components/SourceForm.tsx +++ b/airbyte-webapp/src/pages/SourcesPage/pages/CreateSourcePage/components/SourceForm.tsx @@ -16,7 +16,7 @@ interface SourceFormProps { serviceType: string; sourceDefinitionId?: string; connectionConfiguration?: ConnectionConfiguration; - }) => void; + }) => Promise; sourceDefinitions: SourceDefinitionReadWithLatestTag[]; hasSuccess?: boolean; error?: FormError | null; diff --git a/airbyte-webapp/src/views/Connector/ConnectorCard/ConnectorCard.tsx b/airbyte-webapp/src/views/Connector/ConnectorCard/ConnectorCard.tsx index 8162ef054f29..d862c8eaa071 100644 --- a/airbyte-webapp/src/views/Connector/ConnectorCard/ConnectorCard.tsx +++ b/airbyte-webapp/src/views/Connector/ConnectorCard/ConnectorCard.tsx @@ -149,6 +149,8 @@ export const ConnectorCard: React.FC { { + onSubmit={async (values) => { result = values; }} selectedConnectorDefinitionSpecification={ @@ -381,7 +381,7 @@ describe("Service Form", () => { const renderConnectorForm = (props: ConnectorFormProps) => render(); // eslint-disable-next-line @typescript-eslint/no-empty-function - const onSubmitClb = () => {}; + const onSubmitClb = async () => {}; const connectorDefSpec = { connectionSpecification: schema, sourceDefinitionId: "test-service-type", diff --git a/airbyte-webapp/src/views/Connector/ConnectorForm/ConnectorForm.tsx b/airbyte-webapp/src/views/Connector/ConnectorForm/ConnectorForm.tsx index 20a2ecd54803..5c3d739bf8b5 100644 --- a/airbyte-webapp/src/views/Connector/ConnectorForm/ConnectorForm.tsx +++ b/airbyte-webapp/src/views/Connector/ConnectorForm/ConnectorForm.tsx @@ -89,7 +89,7 @@ export interface ConnectorFormProps { formId?: string; selectedConnectorDefinition?: ConnectorDefinition; selectedConnectorDefinitionSpecification?: ConnectorDefinitionSpecification; - onSubmit: (values: ConnectorFormValues) => Promise | void; + onSubmit: (values: ConnectorFormValues) => Promise; isLoading?: boolean; isEditMode?: boolean; formValues?: Partial; diff --git a/airbyte-webapp/src/views/Connector/ConnectorForm/index.stories.tsx b/airbyte-webapp/src/views/Connector/ConnectorForm/index.stories.tsx index af570ff9afe2..9ca0171a17b6 100644 --- a/airbyte-webapp/src/views/Connector/ConnectorForm/index.stories.tsx +++ b/airbyte-webapp/src/views/Connector/ConnectorForm/index.stories.tsx @@ -39,7 +39,7 @@ export default { formValues: { serviceType: TempConnector.sourceDefinitionId, }, - onSubmit: (v) => console.log(v), + onSubmit: async (v) => console.log(v), availableServices: [TempConnector], }, decorators: [withMock],