From bb39b36016ca32baba3a762ee2a56fe3da358bcc Mon Sep 17 00:00:00 2001
From: Yurii Bidiuk <35812734+yurii-bidiuk@users.noreply.github.com>
Date: Thu, 22 Sep 2022 18:03:26 +0300
Subject: [PATCH] Destiantion Kinesis: add required fields (#16952)

* Destiantion Kinesis: add required fields

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
---
 .../src/main/resources/seed/destination_definitions.yaml  | 2 +-
 .../init/src/main/resources/seed/destination_specs.yaml   | 8 +++++++-
 .../connectors/destination-kinesis/Dockerfile             | 2 +-
 .../destination-kinesis/src/main/resources/spec.json      | 4 +++-
 docs/integrations/destinations/kinesis.md                 | 4 ++--
 5 files changed, 14 insertions(+), 6 deletions(-)

diff --git a/airbyte-config/init/src/main/resources/seed/destination_definitions.yaml b/airbyte-config/init/src/main/resources/seed/destination_definitions.yaml
index c44542eda5863..9aa8a59924402 100644
--- a/airbyte-config/init/src/main/resources/seed/destination_definitions.yaml
+++ b/airbyte-config/init/src/main/resources/seed/destination_definitions.yaml
@@ -140,7 +140,7 @@
 - name: Kinesis
   destinationDefinitionId: 6d1d66d4-26ab-4602-8d32-f85894b04955
   dockerRepository: airbyte/destination-kinesis
-  dockerImageTag: 0.1.4
+  dockerImageTag: 0.1.5
   documentationUrl: https://docs.airbyte.io/integrations/destinations/kinesis
   icon: kinesis.svg
   releaseStage: alpha
diff --git a/airbyte-config/init/src/main/resources/seed/destination_specs.yaml b/airbyte-config/init/src/main/resources/seed/destination_specs.yaml
index 889f6d83a7ce1..43186bdfd42bb 100644
--- a/airbyte-config/init/src/main/resources/seed/destination_specs.yaml
+++ b/airbyte-config/init/src/main/resources/seed/destination_specs.yaml
@@ -2303,7 +2303,7 @@
     supportsDBT: false
     supported_destination_sync_modes:
     - "append"
-- dockerImage: "airbyte/destination-kinesis:0.1.4"
+- dockerImage: "airbyte/destination-kinesis:0.1.5"
   spec:
     documentationUrl: "https://docs.airbyte.io/integrations/destinations/kinesis"
     connectionSpecification:
@@ -2311,6 +2311,8 @@
       title: "Kinesis Destination Spec"
       type: "object"
       required:
+      - "endpoint"
+      - "region"
       - "shardCount"
       - "accessKey"
       - "privateKey"
@@ -2321,12 +2323,16 @@
           title: "Endpoint"
           description: "AWS Kinesis endpoint."
           type: "string"
+          examples:
+          - "kinesis.us‑west‑1.amazonaws.com"
           order: 0
         region:
           title: "Region"
           description: "AWS region. Your account determines the Regions that are available\
             \ to you."
           type: "string"
+          examples:
+          - "us‑west‑1"
           order: 1
         shardCount:
           title: "Shard Count"
diff --git a/airbyte-integrations/connectors/destination-kinesis/Dockerfile b/airbyte-integrations/connectors/destination-kinesis/Dockerfile
index 05a5d4bd26d66..46b79096cbce3 100644
--- a/airbyte-integrations/connectors/destination-kinesis/Dockerfile
+++ b/airbyte-integrations/connectors/destination-kinesis/Dockerfile
@@ -16,5 +16,5 @@ ENV APPLICATION destination-kinesis
 
 COPY --from=build /airbyte /airbyte
 
-LABEL io.airbyte.version=0.1.4
+LABEL io.airbyte.version=0.1.5
 LABEL io.airbyte.name=airbyte/destination-kinesis
diff --git a/airbyte-integrations/connectors/destination-kinesis/src/main/resources/spec.json b/airbyte-integrations/connectors/destination-kinesis/src/main/resources/spec.json
index 65aea2da4e20d..476716e66b7fe 100644
--- a/airbyte-integrations/connectors/destination-kinesis/src/main/resources/spec.json
+++ b/airbyte-integrations/connectors/destination-kinesis/src/main/resources/spec.json
@@ -8,19 +8,21 @@
     "$schema": "http://json-schema.org/draft-07/schema#",
     "title": "Kinesis Destination Spec",
     "type": "object",
-    "required": ["shardCount", "accessKey", "privateKey", "bufferSize"],
+    "required": ["endpoint", "region", "shardCount", "accessKey", "privateKey", "bufferSize"],
     "additionalProperties": true,
     "properties": {
       "endpoint": {
         "title": "Endpoint",
         "description": "AWS Kinesis endpoint.",
         "type": "string",
+        "examples": ["kinesis.us‑west‑1.amazonaws.com"],
         "order": 0
       },
       "region": {
         "title": "Region",
         "description": "AWS region. Your account determines the Regions that are available to you.",
         "type": "string",
+        "examples": ["us‑west‑1"],
         "order": 1
       },
       "shardCount": {
diff --git a/docs/integrations/destinations/kinesis.md b/docs/integrations/destinations/kinesis.md
index c6788dc8f7f88..2985df9daf985 100644
--- a/docs/integrations/destinations/kinesis.md
+++ b/docs/integrations/destinations/kinesis.md
@@ -35,8 +35,8 @@ The connector buffer size should also be tweaked according to your data size and
 
 * The connector is compatible with the latest Kinesis service version at the time of this writing. 
 * Configuration
-    * **_Endpoint_**(`Optional`): Aws Kinesis endpoint to connect to. Default endpoint if not provided   
-    * **_Region_**(`Optional`): Aws Kinesis region to connect to. Default region if not provided.  
+    * **_Endpoint_**: Aws Kinesis endpoint to connect to. Default endpoint if not provided   
+    * **_Region_**: Aws Kinesis region to connect to. Default region if not provided.  
     * **_shardCount_**: The number of shards with which the stream should be created. The amount of shards affects the throughput of your stream. 
     * **_accessKey_**: Access key credential for authenticating with the service.  
     * **_privateKey_**: Private key credential for authenticating with the service.