From bf33a5d063c13fc3f799e2364471e1c564302b23 Mon Sep 17 00:00:00 2001 From: Baz Date: Thu, 9 Mar 2023 21:04:54 +0200 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20Source=20Delighted:=20fix=20`Dat?= =?UTF-8?q?e=20Since`=20date-format=20bug=20in=20UI=20(#23909)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../init/src/main/resources/seed/source_definitions.yaml | 2 +- .../init/src/main/resources/seed/source_specs.yaml | 5 +++-- airbyte-integrations/connectors/source-delighted/Dockerfile | 2 +- .../connectors/source-delighted/acceptance-test-config.yml | 2 ++ .../source-delighted/source_delighted/manifest.yaml | 2 +- .../connectors/source-delighted/source_delighted/spec.json | 4 ++-- connectors.md | 2 +- docs/integrations/sources/delighted.md | 1 + 8 files changed, 12 insertions(+), 8 deletions(-) diff --git a/airbyte-config/init/src/main/resources/seed/source_definitions.yaml b/airbyte-config/init/src/main/resources/seed/source_definitions.yaml index 6e6dad42fe4f..7febd764ac3c 100644 --- a/airbyte-config/init/src/main/resources/seed/source_definitions.yaml +++ b/airbyte-config/init/src/main/resources/seed/source_definitions.yaml @@ -452,7 +452,7 @@ - name: Delighted sourceDefinitionId: cc88c43f-6f53-4e8a-8c4d-b284baaf9635 dockerRepository: airbyte/source-delighted - dockerImageTag: 0.2.1 + dockerImageTag: 0.2.2 documentationUrl: https://docs.airbyte.com/integrations/sources/delighted icon: delighted.svg sourceType: api diff --git a/airbyte-config/init/src/main/resources/seed/source_specs.yaml b/airbyte-config/init/src/main/resources/seed/source_specs.yaml index 9f8c3ed8b80c..e90afb42694b 100644 --- a/airbyte-config/init/src/main/resources/seed/source_specs.yaml +++ b/airbyte-config/init/src/main/resources/seed/source_specs.yaml @@ -3145,7 +3145,7 @@ supportsNormalization: false supportsDBT: false supported_destination_sync_modes: [] -- dockerImage: "airbyte/source-delighted:0.2.1" +- dockerImage: "airbyte/source-delighted:0.2.2" spec: documentationUrl: "https://docsurl.com" connectionSpecification: @@ -3168,8 +3168,9 @@ type: "string" description: "The date from which you'd like to replicate the data" examples: + - "2022-05-30T04:50:23Z" - "2022-05-30 04:50:23" - pattern: "^[0-9]{4}-[0-9]{2}-[0-9]{2} ([0-9]{2}:[0-9]{2}:[0-9]{2})?$" + pattern: "^\\d{4}-\\d{2}-\\d{2}[T ]\\d{2}:\\d{2}:\\d{2}(\\.\\d+)?Z?$" order: 1 format: "date-time" supportsNormalization: false diff --git a/airbyte-integrations/connectors/source-delighted/Dockerfile b/airbyte-integrations/connectors/source-delighted/Dockerfile index e2985885f89c..823aa5756ed8 100644 --- a/airbyte-integrations/connectors/source-delighted/Dockerfile +++ b/airbyte-integrations/connectors/source-delighted/Dockerfile @@ -12,5 +12,5 @@ COPY main.py ./. ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py" ENTRYPOINT ["python", "/airbyte/integration_code/main.py"] -LABEL io.airbyte.version=0.2.1 +LABEL io.airbyte.version=0.2.2 LABEL io.airbyte.name=airbyte/source-delighted diff --git a/airbyte-integrations/connectors/source-delighted/acceptance-test-config.yml b/airbyte-integrations/connectors/source-delighted/acceptance-test-config.yml index 40c758778a84..565103f29f6e 100644 --- a/airbyte-integrations/connectors/source-delighted/acceptance-test-config.yml +++ b/airbyte-integrations/connectors/source-delighted/acceptance-test-config.yml @@ -6,6 +6,8 @@ acceptance_tests: spec: tests: - spec_path: "source_delighted/spec.json" + backward_compatibility_tests_config: + disable_for_version: 0.2.1 connection: tests: - config_path: "secrets/config.json" diff --git a/airbyte-integrations/connectors/source-delighted/source_delighted/manifest.yaml b/airbyte-integrations/connectors/source-delighted/source_delighted/manifest.yaml index 62dd2928a3a2..c38a2e902bfc 100644 --- a/airbyte-integrations/connectors/source-delighted/source_delighted/manifest.yaml +++ b/airbyte-integrations/connectors/source-delighted/source_delighted/manifest.yaml @@ -24,7 +24,7 @@ definitions: datetime_format: "%s" cursor_granularity: "PT1S" start_datetime: - datetime: "{{ config['since'] }}" + datetime: "{{ format_datetime(config['since'], '%Y-%m-%d %H:%M:%S') }}" datetime_format: "%Y-%m-%d %H:%M:%S" end_datetime: datetime: "{{ today_utc() }}" diff --git a/airbyte-integrations/connectors/source-delighted/source_delighted/spec.json b/airbyte-integrations/connectors/source-delighted/source_delighted/spec.json index 6c0cd57e7ad0..7de4d10499d6 100644 --- a/airbyte-integrations/connectors/source-delighted/source_delighted/spec.json +++ b/airbyte-integrations/connectors/source-delighted/source_delighted/spec.json @@ -18,8 +18,8 @@ "title": "Date Since", "type": "string", "description": "The date from which you'd like to replicate the data", - "examples": ["2022-05-30 04:50:23"], - "pattern": "^[0-9]{4}-[0-9]{2}-[0-9]{2} ([0-9]{2}:[0-9]{2}:[0-9]{2})?$", + "examples": ["2022-05-30T04:50:23Z", "2022-05-30 04:50:23"], + "pattern": "^\\d{4}-\\d{2}-\\d{2}[T ]\\d{2}:\\d{2}:\\d{2}(\\.\\d+)?Z?$", "order": 1, "format": "date-time" } diff --git a/connectors.md b/connectors.md index 20f43c2311ac..0dc092445e66 100644 --- a/connectors.md +++ b/connectors.md @@ -57,7 +57,7 @@ | **DV 360** | DV 360 icon | Source | airbyte/source-dv-360:0.1.0 | alpha | [link](https://docs.airbyte.com/integrations/sources/dv-360) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-dv-360) | `1356e1d9-977f-4057-ad4b-65f25329cf61` | | **Datadog** | Datadog icon | Source | airbyte/source-datadog:0.1.0 | alpha | [link](https://docs.airbyte.com/integrations/sources/datadog) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-datadog) | `1cfc30c7-82db-43f4-9fd7-ac1b42312cda` | | **Datascope** | Datascope icon | Source | airbyte/source-datascope:0.1.0 | alpha | [link](https://docs.airbyte.com/integrations/sources/datascope) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-datascope) | `8e1ae2d2-4790-44d3-9d83-75b3fc3940ff` | -| **Delighted** | Delighted icon | Source | airbyte/source-delighted:0.2.1 | beta | [link](https://docs.airbyte.com/integrations/sources/delighted) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-delighted) | `cc88c43f-6f53-4e8a-8c4d-b284baaf9635` | +| **Delighted** | Delighted icon | Source | airbyte/source-delighted:0.2.2 | beta | [link](https://docs.airbyte.com/integrations/sources/delighted) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-delighted) | `cc88c43f-6f53-4e8a-8c4d-b284baaf9635` | | **Dixa** | Dixa icon | Source | airbyte/source-dixa:0.1.3 | alpha | [link](https://docs.airbyte.com/integrations/sources/dixa) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-dixa) | `0b5c867e-1b12-4d02-ab74-97b2184ff6d7` | | **Dockerhub** | Dockerhub icon | Source | airbyte/source-dockerhub:0.1.0 | alpha | [link](https://docs.airbyte.com/integrations/sources/dockerhub) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-dockerhub) | `72d405a3-56d8-499f-a571-667c03406e43` | | **Dremio** | Dremio icon | Source | airbyte/source-dremio:0.1.0 | alpha | [link](https://docs.airbyte.com/integrations/sources/dremio) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-dremio) | `d99e9ace-8621-46c2-9144-76ae4751d64b` | diff --git a/docs/integrations/sources/delighted.md b/docs/integrations/sources/delighted.md index 0fd192572a3d..816c525c5de7 100644 --- a/docs/integrations/sources/delighted.md +++ b/docs/integrations/sources/delighted.md @@ -37,6 +37,7 @@ This Source is capable of syncing the following core Streams: | Version | Date | Pull Request | Subject | |:--------|:-----------|:---------------------------------------------------------|:-----------------------------------------------------------------------------------------------------| +| 0.2.2 | 2023-03-09 | [23909](https://github.com/airbytehq/airbyte/pull/23909) | Updated the input config pattern to accept both `RFC3339` and `datetime string` formats in UI | | 0.2.1 | 2023-02-14 | [23009](https://github.com/airbytehq/airbyte/pull/23009) |Specified date formatting in specification | | 0.2.0 | 2022-11-22 | [19822](https://github.com/airbytehq/airbyte/pull/19822) | Migrate to Low code + certify to Beta | | 0.1.4 | 2022-06-10 | [13439](https://github.com/airbytehq/airbyte/pull/13439) | Change since parameter input to iso date |