From c9483316a825b6d08d38fb5f70230fb4775e411e Mon Sep 17 00:00:00 2001 From: Evan Tahler Date: Fri, 9 Dec 2022 11:51:14 -0800 Subject: [PATCH] More destination fixes for `ci_check_dependency` (#20274) --- .../{azureblobstorage.md => azure-blob-storage.md} | 0 docs/integrations/destinations/redpanda.md | 2 ++ tools/bin/ci_check_dependency.py | 11 ++++++----- 3 files changed, 8 insertions(+), 5 deletions(-) rename docs/integrations/destinations/{azureblobstorage.md => azure-blob-storage.md} (100%) diff --git a/docs/integrations/destinations/azureblobstorage.md b/docs/integrations/destinations/azure-blob-storage.md similarity index 100% rename from docs/integrations/destinations/azureblobstorage.md rename to docs/integrations/destinations/azure-blob-storage.md diff --git a/docs/integrations/destinations/redpanda.md b/docs/integrations/destinations/redpanda.md index 2c51c85d501bc..e1f4496a2e6e2 100644 --- a/docs/integrations/destinations/redpanda.md +++ b/docs/integrations/destinations/redpanda.md @@ -58,6 +58,8 @@ More info about this can be found in the [Redpanda producer configs documentatio _NOTE_: Configurations for SSL are not available yet. +## CHANGELOG + | Version | Date | Pull Request | Subject | | :------ | :--------- | :------------------------------------------------------- | :------------- | | 0.1.0 | 2022-08-05 | [18884](https://github.com/airbytehq/airbyte/pull/18884) | Initial commit | diff --git a/tools/bin/ci_check_dependency.py b/tools/bin/ci_check_dependency.py index d394994821026..23a55077aab48 100644 --- a/tools/bin/ci_check_dependency.py +++ b/tools/bin/ci_check_dependency.py @@ -127,10 +127,14 @@ def get_connector_version_status(connector, version): def get_connector_changelog_status(connector: str, version) -> str: - type, name = connector.replace("-strict-encrypt", "").split("-", 1) + type, name = connector.replace("-strict-encrypt", "").replace("-denormalized", "").split("-", 1) doc_path = f"{DOC_PATH}{type}s/{name}.md" + + if any(regex.match(connector) for regex in IGNORED_DESTINATIONS): + return "🔵
(ignored)" if not os.path.exists(doc_path): return "⚠
(doc not found)" + with open(doc_path) as f: after_changelog = False for line in f: @@ -139,10 +143,7 @@ def get_connector_changelog_status(connector: str, version) -> str: if after_changelog and version in line: return "✅" - if any(regex.match(connector) for regex in IGNORED_DESTINATIONS): - return "🔵
(ignored)" - else: - return "❌
(changelog missing)" + return "❌
(changelog missing)" def as_bulleted_markdown_list(items):