Skip to content

🐛 Source MySQL CDC: sync failed when has Zero-date value in mandatory column - #10251

Merged
Andrii Leonets (DoNotPanicUA) merged 8 commits into
masterfrom
aleonets/6884-fix-zero-date-cdc
Feb 11, 2022
Merged

🐛 Source MySQL CDC: sync failed when has Zero-date value in mandatory column#10251
Andrii Leonets (DoNotPanicUA) merged 8 commits into
masterfrom
aleonets/6884-fix-zero-date-cdc

Conversation

@DoNotPanicUA

@DoNotPanicUA Andrii Leonets (DoNotPanicUA) commented Feb 10, 2022

Copy link
Copy Markdown
Contributor

What

An incremental sync fails if not null column has a Zero-date value. The Debezium driver should replace it with the epoch but it left null as for optional.

How

We already set default values for NULL optional values. Now we also analyze if it's a date and still null, put epoch for a mandatory column.

@github-actions github-actions Bot added the area/connectors Connector related issues label Feb 10, 2022
@DoNotPanicUA Andrii Leonets (DoNotPanicUA) linked an issue Feb 10, 2022 that may be closed by this pull request
Source MySQL CDC: sync failed when has null value in created_at column #6884
Closed
@DoNotPanicUA Andrii Leonets (DoNotPanicUA) changed the title Source MySQL CDC: sync failed when has Zero-date value in mandatory column 🐛 Source MySQL CDC: sync failed when has Zero-date value in mandatory column Feb 10, 2022
@DoNotPanicUA
Andrii Leonets (DoNotPanicUA) temporarily deployed to more-secrets February 10, 2022 21:14 Inactive
@DoNotPanicUA

Andrii Leonets (DoNotPanicUA) commented Feb 10, 2022 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/test connector=source-mysql

🕑 source-mysql https://github.com/airbytehq/airbyte/actions/runs/1826190979
✅ source-mysql https://github.com/airbytehq/airbyte/actions/runs/1826190979
No Python unittests run

@DoNotPanicUA Andrii Leonets (DoNotPanicUA) mentioned this pull request Feb 10, 2022
Closed
@octavia-squidington-iii
Octavia Squidington III (octavia-squidington-iii) temporarily deployed to more-secrets February 10, 2022 21:17 Inactive
@DoNotPanicUA
Andrii Leonets (DoNotPanicUA) marked this pull request as ready for review February 10, 2022 21:50
@DoNotPanicUA

Andrii Leonets (DoNotPanicUA) commented Feb 10, 2022 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/test connector=source-mysql

🕑 source-mysql https://github.com/airbytehq/airbyte/actions/runs/1826503164
✅ source-mysql https://github.com/airbytehq/airbyte/actions/runs/1826503164
No Python unittests run

@DoNotPanicUA
Andrii Leonets (DoNotPanicUA) temporarily deployed to more-secrets February 10, 2022 22:35 Inactive
@octavia-squidington-iii
Octavia Squidington III (octavia-squidington-iii) temporarily deployed to more-secrets February 10, 2022 22:36 Inactive
mkhokh-33
mkhokh-33 reviewed Feb 11, 2022
View reviewed changes
Comment thread airbyte-integrations/connectors/source-mysql/Dockerfile Outdated
COPY --from=build /airbyte /airbyte

LABEL io.airbyte.version=0.5.2
LABEL io.airbyte.version=0.5.3

@mkhokh-33 mkhokh-33 Feb 11, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we update source-mysql-strict-encrypt as well?

@DoNotPanicUA
Andrii Leonets (DoNotPanicUA) temporarily deployed to more-secrets February 11, 2022 09:39 Inactive
@mkhokh-33

mkhokh-33 commented Feb 11, 2022 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

/test connector=source-mysql-strict-encrypt

🕑 source-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1828690580
✅ source-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1828690580
No Python unittests run

@octavia-squidington-iii
Octavia Squidington III (octavia-squidington-iii) temporarily deployed to more-secrets February 11, 2022 10:07 Inactive
@DoNotPanicUA
Andrii Leonets (DoNotPanicUA) temporarily deployed to more-secrets February 11, 2022 11:01 Inactive
@github-actions github-actions Bot added the area/documentation Improvements or additions to documentation label Feb 11, 2022
@DoNotPanicUA
Andrii Leonets (DoNotPanicUA) temporarily deployed to more-secrets February 11, 2022 12:00 Inactive
alexandr-shegeda
Oleksandr Sheheda (alexandr-shegeda) approved these changes Feb 11, 2022
View reviewed changes

@alexandr-shegeda Oleksandr Sheheda (alexandr-shegeda) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DoNotPanicUA

Andrii Leonets (DoNotPanicUA) commented Feb 11, 2022 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/test connector=connectors/source-mysql-strict-encrypt

🕑 connectors/source-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1829561470
✅ connectors/source-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1829561470
No Python unittests run

@DoNotPanicUA

Andrii Leonets (DoNotPanicUA) commented Feb 11, 2022 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/test connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/1829565691
✅ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/1829565691
No Python unittests run

@DoNotPanicUA

Andrii Leonets (DoNotPanicUA) commented Feb 11, 2022 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/publish connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/1829566400
❌ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/1829566400

@DoNotPanicUA

Andrii Leonets (DoNotPanicUA) commented Feb 11, 2022 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/publish connector=connectors/source-mysql-strict-encrypt

🕑 connectors/source-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1829567085
❌ connectors/source-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1829567085

@octavia-squidington-iii
Octavia Squidington III (octavia-squidington-iii) temporarily deployed to more-secrets February 11, 2022 13:35 Inactive
@octavia-squidington-iii
Octavia Squidington III (octavia-squidington-iii) temporarily deployed to more-secrets February 11, 2022 13:35 Inactive
@octavia-squidington-iii
Octavia Squidington III (octavia-squidington-iii) temporarily deployed to more-secrets February 11, 2022 13:35 Inactive
@octavia-squidington-iii
Octavia Squidington III (octavia-squidington-iii) temporarily deployed to more-secrets February 11, 2022 13:35 Inactive
@alexandr-shegeda

Oleksandr Sheheda (alexandr-shegeda) commented Feb 11, 2022

Copy link
Copy Markdown
Contributor

Andrii Leonets (@DoNotPanicUA) we can proceed with publishing and merging without airbyte review

@DoNotPanicUA

Andrii Leonets (DoNotPanicUA) commented Feb 11, 2022 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/test connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/1829964597
✅ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/1829964597
No Python unittests run

@DoNotPanicUA

Andrii Leonets (DoNotPanicUA) commented Feb 11, 2022 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/publish connector=connectors/source-mysql-strict-encrypt

🕑 connectors/source-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1829965307
✅ connectors/source-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1829965307

@DoNotPanicUA

Andrii Leonets (DoNotPanicUA) commented Feb 11, 2022 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/publish connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/1829967143
✅ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/1829967143

@DoNotPanicUA
Andrii Leonets (DoNotPanicUA) temporarily deployed to more-secrets February 11, 2022 15:02 Inactive
@octavia-squidington-iii
Octavia Squidington III (octavia-squidington-iii) temporarily deployed to more-secrets February 11, 2022 15:04 Inactive
@octavia-squidington-iii
Octavia Squidington III (octavia-squidington-iii) temporarily deployed to more-secrets February 11, 2022 15:04 Inactive
@octavia-squidington-iii
Octavia Squidington III (octavia-squidington-iii) temporarily deployed to more-secrets February 11, 2022 15:04 Inactive
@DoNotPanicUA
Andrii Leonets (DoNotPanicUA) temporarily deployed to more-secrets February 11, 2022 15:15 Inactive
@DoNotPanicUA
Andrii Leonets (DoNotPanicUA) deleted the aleonets/6884-fix-zero-date-cdc branch February 11, 2022 15:53
Merged

This branch was previously deployed

1 inactive deployment
more-secrets — 2a0ee89c Deployed Feb 11, 2022 by DoNotPanicUA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@alexandr-shegeda Oleksandr Sheheda (alexandr-shegeda) alexandr-shegeda approved these changes
@mkhokh-33 mkhokh-33 mkhokh-33 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@DoNotPanicUA Andrii Leonets (DoNotPanicUA)

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Source MySQL CDC: sync failed when has null value in created_at column

4 participants

@DoNotPanicUA @mkhokh-33 @alexandr-shegeda @octavia-squidington-iii