Repository navigation
🎉Source Facebook Marketing: use AdAccount('act_{id}') to find account instead of iterating - #11751
Conversation
|
Thank you for your contribution Mahdi Dibaiee (@mdibaiee). As this connector has the General Availability status we need our connector team to give a review. I'm going to run the acceptance test first. |
|
/test connector=connectors/source-facebook-marketing
|
Augustin (alafanechere)
left a comment
There was a problem hiding this comment.
Mahdi Dibaiee (@mdibaiee) could you please update/create the unit tests related to the function you updated?
|
/test connector=connectors/source-facebook-marketing
|
|
/test connector=connectors/source-facebook-marketing
|
|
Pls, publish/merge after #11801. |
|
/publish connector=connectors/source-facebook-marketing auto-bump-version=false
|
Augustin (alafanechere)
left a comment
There was a problem hiding this comment.
Thank you for your contribution Mahdi Dibaiee (@mdibaiee)! Ready to merge
… instead of iterating (#11751)
resolves #11750
What
How
Recommended reading order
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing/publishcommand described hereTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.