Repository navigation
update some connectors to use YAML specs - #12230
Conversation
|
/test connector=connectors/source-stripe
|
|
/test connector=connectors/source-salesforce
|
|
/test connector=connectors/source-hubspot
|
|
/test connector=connectors/source-google-sheets
|
|
/test connector=connectors/source-exchange-rates
|
|
/test connector=connectors/source-hubspot
|
| packages=find_packages(), | ||
| install_requires=MAIN_REQUIREMENTS, | ||
| package_data={"": ["*.json", "schemas/*.json", "schemas/shared/*.json"]}, | ||
| package_data={"": ["*.json", "*.yaml", "schemas/*.json", "schemas/shared/*.json"]}, |
There was a problem hiding this comment.
note: not adding *.yaml here weirdly didn't seem to cause any issues 🤔
| @@ -0,0 +1,47 @@ | |||
| documentationUrl: https://docs.airbyte.io/integrations/sources/stripe | |||
| connectionSpecification: | |||
| $schema: http://json-schema.org/draft-07/schema# | |||
There was a problem hiding this comment.
feels a little odd to be doing this in a yaml file, but I think it's still right?
| type: string | ||
| title: Credentials Title | ||
| description: Name of the credentials set | ||
| const: OAuth Credentials |
There was a problem hiding this comment.
This is slightly different than the spec.json counterpart: previously default and enum were defined, but it looks like that's not necessary anymore and was causing test failures.
There was a problem hiding this comment.
Yup! Thanks for the change
|
|
||
| MAIN_REQUIREMENTS = [ | ||
| "airbyte-cdk~=0.1.49", | ||
| "airbyte-cdk~=0.1.55", |
There was a problem hiding this comment.
Just pointing out that I noticed only hubspot has a patch version in the requirements. Others either don't have a version at all, or are set to ~=0.1
|
/publish connector=connectors/source-stripe
|
|
/publish connector=connectors/source-salesforce
|
Codecov Report
@@ Coverage Diff @@
## master #12230 +/- ##
=========================================
Coverage ? 82.93%
=========================================
Files ? 21
Lines ? 1904
Branches ? 0
=========================================
Hits ? 1579
Misses ? 325
Partials ? 0 Continue to review full report at Codecov.
|
|
/publish connector=connectors/source-hubspot
|
|
/publish connector=connectors/source-google-sheets auto-bump-version=false
|
|
/publish connector=connectors/source-exchange-rates auto-bump-version=false
|
* salesforce uses spec.yaml * stripe uses spec.yaml * revert unintended changes * bump stripe version * add yaml files to package_data * hubspot uses a spec.yaml * use double quotes in yaml files * google sheets uses spec.yaml * exhcange-rates uses spec.yaml * remove usage of default and enum in spec * bump hubspot cdk requirement * auto-bump connector version * auto-bump connector version * manually bump versions Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
This branch was previously deployed
3 participants
What
#11668 introduced yaml spec support, now let's actually use it!
How
Update 5 connectors to use a
spec.yaml:I basically ran the old
spec.jsonfiles through https://codebeautify.org/json-to-yaml and made minor tweaks (mainly change single quotes to double quotes)Also updated some references to the old files and bumped connector versions.
Doc updates coming soon w/ references to new
spec.yamlfiles.