Skip to content

🐞 Postgres source: fix azure database catalog retrieval - #12834

Merged
Liren Tu (tuliren) merged 5 commits into
masterfrom
liren/patch-azure-postgres
May 13, 2022
Merged

🐞 Postgres source: fix azure database catalog retrieval#12834
Liren Tu (tuliren) merged 5 commits into
masterfrom
liren/patch-azure-postgres

Conversation

@tuliren

@tuliren Liren Tu (tuliren) commented May 13, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

What

  • Azure Postgres server has this username pattern: <username>@<host>.
  • However, inside Postgres, the true username is <username>.
  • We need the true username to retrieve tables that are accessible to the user. Using the full username results in an empty catalog.
  • Resolve https://github.com/airbytehq/oncall/issues/225.

How

  • This PR adds a method to return the true username when checking for table permissions.

🚨 User Impact 🚨

  • Currently, users cannot sync any data using the latest Postgres source connector 0.4.14.
  • After this PR is deployed, this issue will be fixed.

@github-actions github-actions Bot added the area/connectors Connector related issues label May 13, 2022
@github-actions github-actions Bot added the area/documentation Improvements or additions to documentation label May 13, 2022
@tuliren

Liren Tu (tuliren) commented May 13, 2022 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/2317831000
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/2317831000
No Python unittests run

@tuliren

Liren Tu (tuliren) commented May 13, 2022 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/test connector=connectors/source-postgres-strict-encrypt

🕑 connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2317831659
✅ connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2317831659
No Python unittests run

@tuliren

Liren Tu (tuliren) commented May 13, 2022 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/publish connector=connectors/source-postgres run-tests=false

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/2318116191
🚀 Successfully published connectors/source-postgres
🚀 Auto-bumped version for connectors/source-postgres
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/2318116191

@tuliren

Liren Tu (tuliren) commented May 13, 2022 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/publish connector=connectors/source-postgres-strict-encrypt run-tests=false

🕑 connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2318116843
🚀 Successfully published connectors/source-postgres-strict-encrypt
❌ Couldn't auto-bump version for connectors/source-postgres-strict-encrypt

@octavia-squidington-iii
Octavia Squidington III (octavia-squidington-iii) temporarily deployed to more-secrets May 13, 2022 08:23 Inactive
@octavia-squidington-iii
Octavia Squidington III (octavia-squidington-iii) temporarily deployed to more-secrets May 13, 2022 08:23 Inactive
@tuliren
Liren Tu (tuliren) merged commit 7d16fda into master May 13, 2022
@tuliren
Liren Tu (tuliren) deleted the liren/patch-azure-postgres branch May 13, 2022 08:35
Merged
evantahler
Evan Tahler (evantahler) reviewed May 13, 2022
View reviewed changes

@evantahler Evan Tahler (evantahler) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast turn-around!

Yevhen Sukhomud (suhomud) pushed a commit that referenced this pull request May 23, 2022
@tuliren @octavia-squidington-iii @suhomud
🐞 Postgres source: fix azure database catalog retrieval (#12834)
9907cda 
* Remove host in azure username

* Bump version

* Fix test

* Replace host with jdbc_url

* auto-bump connector version

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

This branch was previously deployed

1 inactive deployment
more-secrets — 977f6f10 Deployed May 13, 2022 by octavia-squidington-iii
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@evantahler Evan Tahler (evantahler) evantahler left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tuliren @evantahler @octavia-squidington-iii