Skip to content

Source Salesforce: exclude KnowledgeArticleVersion from bulk api - #16119

Merged
Edward Gao (edgao) merged 4 commits into
masterfrom
edgao/salesforce_KnowledgeArticleVersion
Aug 30, 2022
Merged

Source Salesforce: exclude KnowledgeArticleVersion from bulk api#16119
Edward Gao (edgao) merged 4 commits into
masterfrom
edgao/salesforce_KnowledgeArticleVersion

Conversation

@edgao

Copy link
Copy Markdown
Contributor

Followup to #15901 - do the same thing for another stream

@github-actions github-actions Bot added the area/documentation Improvements or additions to documentation label Aug 29, 2022
@edgao

Edward Gao (edgao) commented Aug 29, 2022

Copy link
Copy Markdown
Contributor Author

/test connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/2952576543
✅ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/2952576543
Python tests coverage:

Name                                 Stmts   Miss  Cover
--------------------------------------------------------
source_salesforce/__init__.py            2      0   100%
source_salesforce/exceptions.py          8      1    88%
source_salesforce/api.py               150     19    87%
source_salesforce/streams.py           307     67    78%
source_salesforce/rate_limiting.py      22      6    73%
source_salesforce/source.py             77     33    57%
source_salesforce/utils.py               8      7    12%
--------------------------------------------------------
TOTAL                                  574    133    77%
Name                                 Stmts   Miss  Cover
--------------------------------------------------------
source_salesforce/utils.py               8      0   100%
source_salesforce/__init__.py            2      0   100%
source_salesforce/source.py             77      6    92%
source_salesforce/api.py               150     14    91%
source_salesforce/exceptions.py          8      1    88%
source_salesforce/rate_limiting.py      22      3    86%
source_salesforce/streams.py           307     42    86%
--------------------------------------------------------
TOTAL                                  574     66    89%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       121     25    79%   21-23, 29-31, 36-43, 48-61, 208-216
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       110     48    56%   23-26, 32, 36, 39-64, 67-69, 72-74, 77-79, 82-84, 87-89, 92-110, 144-146
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1322    463    65%

Build Passed

Test summary info:

All Passed

Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
@edgao

Edward Gao (edgao) commented Aug 30, 2022

Copy link
Copy Markdown
Contributor Author

/publish connector=connectors/source-salesforce

🕑 Publishing the following connectors:
connectors/source-salesforce
https://github.com/airbytehq/airbyte/actions/runs/2953018506


Connector Did it publish? Were definitions generated?
connectors/source-salesforce

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@edgao
Edward Gao (edgao) merged commit ab98441 into master Aug 30, 2022
@edgao
Edward Gao (edgao) deleted the edgao/salesforce_KnowledgeArticleVersion branch August 30, 2022 02:50
robbin han (robbinhan) pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
…bytehq#16119)

* exclude KnowledgeArticleVersion from bulk api

* version bump + changelog

* add other affected KnowledgeArticle streams

Co-authored-by: Sherif A. Nada <snadalive@gmail.com>

* auto-bump connector version [ci skip]

Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/salesforce

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants