Skip to content

Destination BigQuery: add user-agent header - #16890

Merged
Yurii Bidiuk (yurii-bidiuk) merged 9 commits into
masterfrom
bidiuk/16615-dest-bigquery-add-user-agent
Sep 26, 2022
Merged

Yurii Bidiuk (yurii-bidiuk) merged 9 commits into
masterfrom
bidiuk/16615-dest-bigquery-add-user-agent

Conversation

@yurii-bidiuk

@yurii-bidiuk Yurii Bidiuk (yurii-bidiuk) commented Sep 19, 2022 •

Copy link
Copy Markdown
Contributor

What

Fixes #16615
Fixes #16616

How

Add user-agent header to Google Cloud Storage and BigQuery API builders.

Recommended reading order

  1. BigQueryDestination.java
  2. BigQueryUtils.java

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@github-actions

Copy link
Copy Markdown
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • destination-bigquery-denormalized
  • destination-bigquery

@github-actions

Copy link
Copy Markdown
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • destination-bigquery-denormalized
  • destination-bigquery

@yurii-bidiuk

Yurii Bidiuk (yurii-bidiuk) commented Sep 20, 2022 •

Copy link
Copy Markdown
Contributor Author

/test connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/3089274913
❌ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/3089274913
🐛 https://gradle.com/s/nzsogvxzzmlp6

Build Failed

Test summary info:

Could not find result summary

@yurii-bidiuk

Yurii Bidiuk (yurii-bidiuk) commented Sep 20, 2022 •

Copy link
Copy Markdown
Contributor Author

/test connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/3089276225
❌ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/3089276225
🐛 https://gradle.com/s/rbpexl6yt2dc6

Build Failed

Test summary info:

Could not find result summary

@yurii-bidiuk

Copy link
Copy Markdown
Contributor Author

destination-bigquery-denormalized extends from destination-bigquery and uses the same Stage and BigQuery API setup, so this PR also fixes #16616

@yurii-bidiuk Yurii Bidiuk (yurii-bidiuk) changed the title Destiantion BigQuery: add user-agent header Destination BigQuery: add user-agent header Sep 20, 2022
@yurii-bidiuk

Yurii Bidiuk (yurii-bidiuk) commented Sep 20, 2022 •

Copy link
Copy Markdown
Contributor Author

/test connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/3089540594
✅ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/3089540594
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 14      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    14      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     166      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         191     49    74%
normalization/transform_catalog/utils.py                             51     14    73%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 589    394    33%
-------------------------------------------------------------------------------------
TOTAL                                                              1437    624    57%

Build Passed

Test summary info:

All Passed

@yurii-bidiuk

Yurii Bidiuk (yurii-bidiuk) commented Sep 20, 2022 •

Copy link
Copy Markdown
Contributor Author

/test connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/3089541402
✅ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/3089541402
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 14      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    14      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     166      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         191     49    74%
normalization/transform_catalog/utils.py                             51     14    73%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 589    394    33%
-------------------------------------------------------------------------------------
TOTAL                                                              1437    624    57%

Build Passed

Test summary info:

All Passed

@github-actions

Copy link
Copy Markdown
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • destination-bigquery
  • destination-bigquery-denormalized

1 similar comment
@github-actions

Copy link
Copy Markdown
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • destination-bigquery
  • destination-bigquery-denormalized

@github-actions

Copy link
Copy Markdown
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • destination-bigquery-denormalized
  • destination-bigquery

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. we can proceed with publishing and merging without airbyte review

@yurii-bidiuk
Yurii Bidiuk (yurii-bidiuk) force-pushed the bidiuk/16615-dest-bigquery-add-user-agent branch from e4c33b2 to 645aa77 Compare September 26, 2022 14:02
@yurii-bidiuk

Yurii Bidiuk (yurii-bidiuk) commented Sep 26, 2022 •

Copy link
Copy Markdown
Contributor Author

/test connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/3128378466
✅ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/3128378466
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 14      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    14      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     166      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         191     49    74%
normalization/transform_catalog/utils.py                             51     14    73%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 589    394    33%
-------------------------------------------------------------------------------------
TOTAL                                                              1437    624    57%

Build Passed

Test summary info:

All Passed

@github-actions github-actions Bot added the area/documentation Improvements or additions to documentation label Sep 26, 2022
@yurii-bidiuk

Yurii Bidiuk (yurii-bidiuk) commented Sep 26, 2022 •

Copy link
Copy Markdown
Contributor Author

/test connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/3128378895
✅ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/3128378895
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 14      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    14      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     166      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         191     49    74%
normalization/transform_catalog/utils.py                             51     14    73%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 589    394    33%
-------------------------------------------------------------------------------------
TOTAL                                                              1437    624    57%

Build Passed

Test summary info:

All Passed

@github-actions

Copy link
Copy Markdown
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • destination-bigquery
  • destination-bigquery-denormalized

@yurii-bidiuk

Yurii Bidiuk (yurii-bidiuk) commented Sep 26, 2022 •

Copy link
Copy Markdown
Contributor Author

/publish connector=connectors/destination-bigquery

🕑 Publishing the following connectors:
connectors/destination-bigquery
https://github.com/airbytehq/airbyte/actions/runs/3129219501


Connector Did it publish? Were definitions generated?
connectors/destination-bigquery ✅ ✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@yurii-bidiuk

Yurii Bidiuk (yurii-bidiuk) commented Sep 26, 2022 •

Copy link
Copy Markdown
Contributor Author

/publish connector=connectors/destination-bigquery-denormalized

🕑 Publishing the following connectors:
connectors/destination-bigquery-denormalized
https://github.com/airbytehq/airbyte/actions/runs/3129221586


Connector Did it publish? Were definitions generated?
connectors/destination-bigquery-denormalized ✅ ✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@github-actions

Copy link
Copy Markdown
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • destination-bigquery-denormalized
  • destination-bigquery

@octavia-squidington-iii
Octavia Squidington III (octavia-squidington-iii) temporarily deployed to more-secrets September 26, 2022 16:56 Inactive
@yurii-bidiuk
Yurii Bidiuk (yurii-bidiuk) marked this pull request as ready for review September 26, 2022 17:30
@yurii-bidiuk
Yurii Bidiuk (yurii-bidiuk) deleted the bidiuk/16615-dest-bigquery-add-user-agent branch September 26, 2022 17:31
robbin han (robbinhan) pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
* Destiantion BigQuery: add user-agent header

* fixed comments

* fix tests

* refactor code

* refactoring

* bump version

* auto-bump connector version [ci skip]

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Johan Hammarstedt (jhammarstedt) pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
* Destiantion BigQuery: add user-agent header

* fixed comments

* fix tests

* refactor code

* refactoring

* bump version

* auto-bump connector version [ci skip]

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

This branch was previously deployed

1 inactive deployment
more-secrets — d1b46c7a Deployed Sep 26, 2022 by octavia-squidington-iii
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BigQuery Destination Denormalized should meet Partner Attribution requirements BigQuery Destination should meet Partner Attribution requirements

3 participants