Skip to content

Make error more descriptive in case of no encryption state - #17299

Merged
Rodi Reich Zilberman (rodireich) merged 9 commits into
masterfrom
16664-improve-user-experience-for-cloud-strict-encrypt-connector-when-configuring-unsecured-connection
Sep 28, 2022
Merged

Make error more descriptive in case of no encryption state#17299
Rodi Reich Zilberman (rodireich) merged 9 commits into
masterfrom
16664-improve-user-experience-for-cloud-strict-encrypt-connector-when-configuring-unsecured-connection

Conversation

@rodireich

@rodireich Rodi Reich Zilberman (rodireich) commented Sep 28, 2022

Copy link
Copy Markdown
Contributor

What

Improve error wording:
Screen Shot 2022-09-27 at 10 27 53 PM

@rodireich Rodi Reich Zilberman (rodireich) linked an issue Sep 28, 2022 that may be closed by this pull request
Improve user experience for cloud strict encrypt connector when configuring unsecured connection #16664
Closed
@github-actions github-actions Bot added the area/connectors Connector related issues label Sep 28, 2022
@rodireich

Rodi Reich Zilberman (rodireich) commented Sep 28, 2022 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/test connector=connectors/source-mysql-strict-encrypt

🕑 connectors/source-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3141089789
❌ connectors/source-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3141089789
🐛 https://gradle.com/s/ski3kk5r2nemg

Build Failed

Test summary info:

Could not find result summary

@rodireich

Rodi Reich Zilberman (rodireich) commented Sep 28, 2022 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/test connector=connectors/source-postgres-strict-encrypt

🕑 connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3141123841
✅ connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3141123841
No Python unittests run

Build Passed

Test summary info:

All Passed

@rodireich

Rodi Reich Zilberman (rodireich) commented Sep 28, 2022 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/test connector=connectors/source-mysql-strict-encrypt

🕑 connectors/source-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3141225375
❌ connectors/source-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3141225375
🐛 https://gradle.com/s/wdx235illv6bw

Build Failed

Test summary info:

Could not find result summary

@rodireich
Merge branch 'master' into 16664-improve-user-experience-for-cloud-st…
addee86 
…rict-encrypt-connector-when-configuring-unsecured-connection
@rodireich
Change error message on strict-encrypt postgres destination as well. …
4720b21 
…Fix failing test
@rodireich
Merge branch '16664-improve-user-experience-for-cloud-strict-encrypt-…
e255c75 
…connector-when-configuring-unsecured-connection' of github.com:airbytehq/airbyte into 16664-improve-user-experience-for-cloud-strict-encrypt-connector-when-configuring-unsecured-connection
@rodireich

Rodi Reich Zilberman (rodireich) commented Sep 28, 2022 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/test connector=connectors/source-mysql-strict-encrypt

🕑 connectors/source-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3141386930
✅ connectors/source-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3141386930
No Python unittests run

Build Passed

Test summary info:

All Passed

@rodireich
Rodi Reich Zilberman (rodireich) marked this pull request as ready for review September 28, 2022 07:04
@github-actions github-actions Bot added the area/documentation Improvements or additions to documentation label Sep 28, 2022
@github-actions

github-actions Bot commented Sep 28, 2022

Copy link
Copy Markdown
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • source-alloydb
  • destination-postgres
  • source-mysql
  • source-postgres-strict-encrypt
  • destination-postgres-strict-encrypt
  • source-alloydb-strict-encrypt
  • source-mysql-strict-encrypt

@rodireich

Rodi Reich Zilberman (rodireich) commented Sep 28, 2022 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/publish connector=connectors/source-postgres,connectors/source-mysql,connectors/destination-postgres

🕑 Publishing the following connectors:
connectors/source-postgres,connectors/source-mysql,connectors/destination-postgres
https://github.com/airbytehq/airbyte/actions/runs/3145361242


Connector Did it publish? Were definitions generated?
connectors/destination-postgres ❌ ❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@rodireich

Rodi Reich Zilberman (rodireich) commented Sep 28, 2022 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/publish connector=connectors/source-postgres-strict-encrypt,connectors/source-mysql-strict-encrypt,connectors/destination-postgres-strict-encrypt auto-bump-version=false

🕑 Publishing the following connectors:
connectors/source-postgres-strict-encrypt,connectors/source-mysql-strict-encrypt,connectors/destination-postgres-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/3145370430


Connector Did it publish? Were definitions generated?
connectors/destination-postgres-strict-encrypt ✅ ❌
connectors/source-mysql-strict-encrypt ✅ ❌
connectors/source-postgres-strict-encrypt ✅ ❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@rodireich

Rodi Reich Zilberman (rodireich) commented Sep 28, 2022 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/publish connector=connectors/source-postgres,connectors/source-mysql,connectors/destination-postgres run-tests=false

Connector Did it publish? Were definitions generated?
connectors/destination-postgres ✅ ✅
connectors/source-mysql ✅ ✅
connectors/source-postgres ✅ ✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@rodireich
Rodi Reich Zilberman (rodireich) deleted the 16664-improve-user-experience-for-cloud-strict-encrypt-connector-when-configuring-unsecured-connection branch September 28, 2022 22:26
robbin han (robbinhan) pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
@rodireich @octavia-squidington-iii @robbinhan
Make error more descriptive in case of no encryption state (airbytehq…
4ab52f0 
…#17299)

* Make error more descriptive in case of no encryption state

* Fix failing test

* Change error message on strict-encrypt postgres destination as well. Fix failing test

* update versions and changelogs

* auto-bump connector version [ci skip]

* auto-bump connector version [ci skip]

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Johan Hammarstedt (jhammarstedt) pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
@rodireich @octavia-squidington-iii @jhammarstedt
Make error more descriptive in case of no encryption state (airbytehq…
4b48d9a 
…#17299)

* Make error more descriptive in case of no encryption state

* Fix failing test

* Change error message on strict-encrypt postgres destination as well. Fix failing test

* update versions and changelogs

* auto-bump connector version [ci skip]

* auto-bump connector version [ci skip]

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@subodh1810 Subodh Chaturvedi (subodh1810) Awaiting requested review from subodh1810
@akashkulk Akash Kulkarni (akashkulk) Awaiting requested review from akashkulk
@grishick Greg Solovyev (grishick) Awaiting requested review from grishick
@ryankfu Ryan Fu (ryankfu) Awaiting requested review from ryankfu
1 more reviewer
@edgao Edward Gao (edgao) edgao approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/postgres connectors/destination/postgres-strict-encrypt connectors/source/mysql connectors/source/mysql-strict-encrypt connectors/source/postgres connectors/source/postgres-strict-encrypt

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve user experience for cloud strict encrypt connector when configuring unsecured connection

4 participants

@rodireich @edgao @octavia-squidington-iii @octavia-squidington-iv