Skip to content

Destination Bigquery: log the full stacktrace rather than just message - #18162

Merged
Edward Gao (edgao) merged 5 commits into
masterfrom
edgao/dest_bigquery_logging
Oct 19, 2022
Merged

Destination Bigquery: log the full stacktrace rather than just message#18162
Edward Gao (edgao) merged 5 commits into
masterfrom
edgao/dest_bigquery_logging

Conversation

@edgao

@edgao Edward Gao (edgao) commented Oct 19, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@edgao
Edward Gao (edgao) requested a review from a team as a code owner October 19, 2022 15:07
@github-actions github-actions Bot added the area/connectors Connector related issues label Oct 19, 2022
@github-actions

github-actions Bot commented Oct 19, 2022

Copy link
Copy Markdown
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • destination-bigquery
  • destination-gcs
  • destination-snowflake
  • destination-bigquery-denormalized

@github-actions github-actions Bot added the area/documentation Improvements or additions to documentation label Oct 19, 2022
@edgao

Edward Gao (edgao) commented Oct 19, 2022 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/publish connector=connectors/destination-bigquery

🕑 Publishing the following connectors:
connectors/destination-bigquery
https://github.com/airbytehq/airbyte/actions/runs/3282882322


Connector Did it publish? Were definitions generated?
connectors/destination-bigquery ✅ ✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@edgao

Edward Gao (edgao) commented Oct 19, 2022 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/publish connector=connectors/destination-bigquery-denormalized

🕑 Publishing the following connectors:
connectors/destination-bigquery-denormalized
https://github.com/airbytehq/airbyte/actions/runs/3282879419


Connector Did it publish? Were definitions generated?
connectors/destination-bigquery-denormalized ✅ ✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@github-actions

github-actions Bot commented Oct 19, 2022

Copy link
Copy Markdown
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • destination-bigquery-denormalized
  • destination-gcs
  • destination-bigquery
  • destination-snowflake

ryankfu
Ryan Fu (ryankfu) approved these changes Oct 19, 2022
View reviewed changes

@ryankfu Ryan Fu (ryankfu) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actions Bot commented Oct 19, 2022

Copy link
Copy Markdown
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • destination-bigquery-denormalized
  • destination-gcs
  • destination-bigquery
  • destination-snowflake

@octavia-squidington-iii
Octavia Squidington III (octavia-squidington-iii) temporarily deployed to more-secrets October 19, 2022 16:07 Inactive
@github-actions

github-actions Bot commented Oct 19, 2022

Copy link
Copy Markdown
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • destination-bigquery-denormalized
  • destination-gcs
  • destination-snowflake
  • destination-bigquery

@octavia-squidington-iii
Octavia Squidington III (octavia-squidington-iii) temporarily deployed to more-secrets October 19, 2022 16:20 Inactive
@edgao
Edward Gao (edgao) merged commit e21d54f into master Oct 19, 2022
@edgao
Edward Gao (edgao) deleted the edgao/dest_bigquery_logging branch October 19, 2022 16:23
Merged
Johan Hammarstedt (jhammarstedt) pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
@edgao @octavia-squidington-iii @jhammarstedt
Destination Bigquery: log the full stacktrace rather than just message (
3e8f4cf 
airbytehq#18162)

* log the full stacktrace rather than just message

* version bumps + changelog

* auto-bump connector version

* auto-bump connector version

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
@grishick Greg Solovyev (grishick) added the team/destinations Destinations team's backlog label Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@etsybaev Eugene (etsybaev) etsybaev approved these changes
@suhomud Yevhen Sukhomud (suhomud) suhomud approved these changes
@ryankfu Ryan Fu (ryankfu) ryankfu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/bigquery connectors/destination/bigquery-denormalized connectors/destination/gcs team/destinations Destinations team's backlog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@edgao @etsybaev @suhomud @ryankfu @grishick @octavia-squidington-iii @octavia-squidington-iv