Repository navigation
🐛Destination-Snowflake: updated check method to handle more errors - #18970
Eugene (etsybaev) merged 16 commits into
Conversation
…ive Warehouse" error
Affected Connector ReportNOTE
|
| Connector | Version | Changelog | Publish |
|---|
- See "Actionable Items" below for how to resolve warnings and errors.
❌ Destinations (20)
| Connector | Version | Changelog | Publish |
|---|---|---|---|
destination-azure-blob-storage |
0.1.6 |
⚠ (doc not found) |
✅ |
destination-clickhouse |
0.2.0 |
✅ | ✅ |
destination-clickhouse-strict-encrypt |
0.2.0 |
✅ | ⚠ (not in seed) |
destination-databricks |
0.3.1 |
✅ | ✅ |
destination-dynamodb |
0.1.7 |
✅ | ✅ |
destination-gcs |
0.2.12 |
✅ | ✅ |
destination-mariadb-columnstore |
0.1.7 |
✅ | ✅ |
destination-mssql |
0.1.22 |
✅ | ✅ |
destination-mssql-strict-encrypt |
0.1.22 |
✅ | ⚠ (not in seed) |
destination-mysql |
0.1.20 |
✅ | ✅ |
destination-mysql-strict-encrypt |
❌ 0.1.21(mismatch: 0.1.20) |
✅ | ⚠ (not in seed) |
destination-oracle |
0.1.19 |
✅ | ✅ |
destination-oracle-strict-encrypt |
0.1.19 |
✅ | ⚠ (not in seed) |
destination-postgres |
0.3.26 |
✅ | ✅ |
destination-postgres-strict-encrypt |
0.3.26 |
✅ | ⚠ (not in seed) |
destination-redshift |
0.3.51 |
✅ | ✅ |
destination-rockset |
0.1.4 |
❌ (changelog missing) |
✅ |
destination-snowflake |
0.4.39 |
✅ | ✅ |
destination-tidb |
0.1.0 |
✅ | ✅ |
destination-yugabytedb |
0.1.0 |
✅ | ✅ |
- See "Actionable Items" below for how to resolve warnings and errors.
Actionable Items
(click to expand)
| Category | Status | Actionable Item |
|---|---|---|
| Version | ❌ mismatch |
The version of the connector is different from its normal variant. Please bump the version of the connector. |
| ⚠ doc not found |
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug. |
|
| Changelog | ⚠ doc not found |
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug. |
| ❌ changelog missing |
There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog. | |
| Publish | ⚠ not in seed |
The connector is not in the seed file (e.g. source_definitions.yaml), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug. |
| ❌ diff seed version |
The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the /publish command to publish the latest version. |
…ix-to-check-method
…ix-to-check-method
|
/test connector=connectors/destination-snowflake
Build PassedTest summary info: |
Ryan Fu (ryankfu)
left a comment
There was a problem hiding this comment.
Update javadoc comments then should be good
Ryan Fu (ryankfu)
left a comment
There was a problem hiding this comment.
Looks good, let's also link the ticket for updating attemptSQLCreateAndDropTableOperations but otherwise looks good
…ix-to-check-method
|
/test connector=connectors/destination-snowflake
Build PassedTest summary info: |
…ix-to-check-method
…ix-to-check-method
…ix-to-check-method
…ix-to-check-method
|
/test connector=connectors/destination-snowflake
Build PassedTest summary info: |
|
/publish connector=connectors/destination-snowflake
if you have connectors that successfully published but failed definition generation, follow step 4 here |
…18970) * [16833] Destination-Snowflake: updated check method to handle "No Active Warehouse" error or user has incorrect permissions
What
Closes #16833
We have 2 known errors that may occur during Sync stage, but the Check method doesn't handle it.
How
Updated check method to handle at least 2 more errors:
Created a follow-up ticket https://app.zenhub.com/workspaces/destinations-6332532d6893ce001c7a56a7/issues/airbytehq/airbyte/19113
Tested locally:


Tested with valid creds, still can connect:

Recommended reading order
AbstractJdbcDestination.javaSnowflakeInsertDestinationAcceptanceTest.java🚨 User Impact 🚨
No user impact expected for existing users
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampledocs/integrations/README.mdairbyte-integrations/builds.mdAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing/publishcommand described hereUpdating a connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing/publishcommand described hereConnector Generator
-scaffoldin their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplatesthen checking in your changesTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.