From 4185160b2c7d294c3d88b61575520ed39de4640e Mon Sep 17 00:00:00 2001 From: ievgeniit Date: Sat, 5 Nov 2022 13:56:43 +0100 Subject: [PATCH 1/3] Fixed tests for destination connectors --- .../DestinationAcceptanceTest.java | 21 +++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/airbyte-integrations/bases/standard-destination-test/src/main/java/io/airbyte/integrations/standardtest/destination/DestinationAcceptanceTest.java b/airbyte-integrations/bases/standard-destination-test/src/main/java/io/airbyte/integrations/standardtest/destination/DestinationAcceptanceTest.java index f73f961402008c..4f575272d4e6ee 100644 --- a/airbyte-integrations/bases/standard-destination-test/src/main/java/io/airbyte/integrations/standardtest/destination/DestinationAcceptanceTest.java +++ b/airbyte-integrations/bases/standard-destination-test/src/main/java/io/airbyte/integrations/standardtest/destination/DestinationAcceptanceTest.java @@ -1217,16 +1217,15 @@ protected void runSyncAndVerifyStateOutput(final JsonNode config, final List destinationOutput = runSync(config, messages, catalog, runNormalization); - Collections.reverse(messages); - final AirbyteMessage expectedStateMessage = messages + + final AirbyteMessage expectedStateMessage = reversed(messages) .stream() .filter(m -> m.getType() == Type.STATE) .findFirst() .orElseThrow(() -> new IllegalArgumentException( "All message sets used for testing should include a state record")); - Collections.reverse(destinationOutput); - final AirbyteMessage actualStateMessage = destinationOutput + final AirbyteMessage actualStateMessage = reversed(destinationOutput) .stream() .filter(m -> m.getType() == Type.STATE) .findFirst() @@ -1238,6 +1237,20 @@ protected void runSyncAndVerifyStateOutput(final JsonNode config, assertEquals(expectedStateMessage, actualStateMessage); } + /** + * Reverses a list by creating a new list with the same elements of the input list and then + * reversing it. The input list will not be altered. + * + * @param list to reverse + * @param type + * @return new list with elements of original reversed. + */ + public static List reversed(final List list) { + final ArrayList reversed = new ArrayList<>(list); + Collections.reverse(reversed); + return reversed; + } + private List runSync( final JsonNode config, final List messages, From 0a015c956207956a188951b17b1ca7292827861b Mon Sep 17 00:00:00 2001 From: ievgeniit Date: Sat, 5 Nov 2022 14:36:00 +0100 Subject: [PATCH 2/3] Fixed tests for destination connectors --- .../standardtest/destination/DestinationAcceptanceTest.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/airbyte-integrations/bases/standard-destination-test/src/main/java/io/airbyte/integrations/standardtest/destination/DestinationAcceptanceTest.java b/airbyte-integrations/bases/standard-destination-test/src/main/java/io/airbyte/integrations/standardtest/destination/DestinationAcceptanceTest.java index 4f575272d4e6ee..47496d51efb981 100644 --- a/airbyte-integrations/bases/standard-destination-test/src/main/java/io/airbyte/integrations/standardtest/destination/DestinationAcceptanceTest.java +++ b/airbyte-integrations/bases/standard-destination-test/src/main/java/io/airbyte/integrations/standardtest/destination/DestinationAcceptanceTest.java @@ -1225,7 +1225,8 @@ protected void runSyncAndVerifyStateOutput(final JsonNode config, .orElseThrow(() -> new IllegalArgumentException( "All message sets used for testing should include a state record")); - final AirbyteMessage actualStateMessage = reversed(destinationOutput) + Collections.reverse(destinationOutput); + final AirbyteMessage actualStateMessage = destinationOutput .stream() .filter(m -> m.getType() == Type.STATE) .findFirst() From f016195a832874a60a82e2b2423684194bd6f261 Mon Sep 17 00:00:00 2001 From: ievgeniit Date: Sat, 5 Nov 2022 14:52:17 +0100 Subject: [PATCH 3/3] Fixed tests for destination connectors --- .../standardtest/destination/DestinationAcceptanceTest.java | 1 - 1 file changed, 1 deletion(-) diff --git a/airbyte-integrations/bases/standard-destination-test/src/main/java/io/airbyte/integrations/standardtest/destination/DestinationAcceptanceTest.java b/airbyte-integrations/bases/standard-destination-test/src/main/java/io/airbyte/integrations/standardtest/destination/DestinationAcceptanceTest.java index 47496d51efb981..899f7cb3ff000f 100644 --- a/airbyte-integrations/bases/standard-destination-test/src/main/java/io/airbyte/integrations/standardtest/destination/DestinationAcceptanceTest.java +++ b/airbyte-integrations/bases/standard-destination-test/src/main/java/io/airbyte/integrations/standardtest/destination/DestinationAcceptanceTest.java @@ -1217,7 +1217,6 @@ protected void runSyncAndVerifyStateOutput(final JsonNode config, final List destinationOutput = runSync(config, messages, catalog, runNormalization); - final AirbyteMessage expectedStateMessage = reversed(messages) .stream() .filter(m -> m.getType() == Type.STATE)