From d816553db50344facac163dbbc86e1fc2e7804ba Mon Sep 17 00:00:00 2001 From: jdpgrailsdev Date: Fri, 2 Dec 2022 11:15:10 -0500 Subject: [PATCH] Always surface normalization failure reason --- .../airbyte/workers/general/DefaultNormalizationWorker.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/airbyte-commons-worker/src/main/java/io/airbyte/workers/general/DefaultNormalizationWorker.java b/airbyte-commons-worker/src/main/java/io/airbyte/workers/general/DefaultNormalizationWorker.java index 00a4a45b3e94c..255cc632ca8de 100644 --- a/airbyte-commons-worker/src/main/java/io/airbyte/workers/general/DefaultNormalizationWorker.java +++ b/airbyte-commons-worker/src/main/java/io/airbyte/workers/general/DefaultNormalizationWorker.java @@ -80,17 +80,18 @@ public NormalizationSummary run(final NormalizationInput input, final Path jobRo } } catch (final Exception e) { ApmTraceUtils.addExceptionToTrace(e); + LOGGER.error("Normalization failed for job {}.", jobId, e); buildFailureReasonsAndSetFailure(); } if (cancelled.get()) { - LOGGER.info("Normalization was cancelled."); + LOGGER.info("Normalization was cancelled for job {}.", jobId); } final long endTime = System.currentTimeMillis(); final Duration duration = Duration.ofMillis(endTime - startTime); final String durationDescription = DurationFormatUtils.formatDurationWords(duration.toMillis(), true, true); - LOGGER.info("Normalization executed in {}.", durationDescription); + LOGGER.info("Normalization executed in {} for job {}.", durationDescription, jobId); final NormalizationSummary summary = new NormalizationSummary() .withStartTime(startTime) @@ -98,7 +99,6 @@ public NormalizationSummary run(final NormalizationInput input, final Path jobRo if (!traceFailureReasons.isEmpty()) { summary.setFailures(traceFailureReasons); - LOGGER.error("Normalization Failed."); } else if (failed) { throw new WorkerException("Normalization Failed."); }