From 06ae610111bbd7a237cf5159b3cc7f07468fe34a Mon Sep 17 00:00:00 2001 From: Akash Kulkarni Date: Mon, 5 Dec 2022 19:52:39 -0800 Subject: [PATCH 1/2] Fix test : attempt 1 --- .../SshKeyMySqlSourceAcceptanceTest.java | 17 +++++++++++++++++ .../SshPasswordMySqlSourceAcceptanceTest.java | 17 +++++++++++++++++ 2 files changed, 34 insertions(+) diff --git a/airbyte-integrations/connectors/source-mysql/src/test-integration/java/io/airbyte/integrations/io/airbyte/integration_tests/sources/SshKeyMySqlSourceAcceptanceTest.java b/airbyte-integrations/connectors/source-mysql/src/test-integration/java/io/airbyte/integrations/io/airbyte/integration_tests/sources/SshKeyMySqlSourceAcceptanceTest.java index ab028c24a72f..dcd33ee86576 100644 --- a/airbyte-integrations/connectors/source-mysql/src/test-integration/java/io/airbyte/integrations/io/airbyte/integration_tests/sources/SshKeyMySqlSourceAcceptanceTest.java +++ b/airbyte-integrations/connectors/source-mysql/src/test-integration/java/io/airbyte/integrations/io/airbyte/integration_tests/sources/SshKeyMySqlSourceAcceptanceTest.java @@ -4,10 +4,27 @@ package io.airbyte.integrations.io.airbyte.integration_tests.sources; +import io.airbyte.commons.features.EnvVariableFeatureFlags; +import io.airbyte.integrations.standardtest.source.TestDestinationEnv; import java.nio.file.Path; +import org.junit.jupiter.api.extension.ExtendWith; +import uk.org.webcompere.systemstubs.environment.EnvironmentVariables; +import uk.org.webcompere.systemstubs.jupiter.SystemStub; +import uk.org.webcompere.systemstubs.jupiter.SystemStubsExtension; +@ExtendWith(SystemStubsExtension.class) public class SshKeyMySqlSourceAcceptanceTest extends AbstractSshMySqlSourceAcceptanceTest { + @SystemStub + private EnvironmentVariables environmentVariables; + + @Override + protected void setupEnvironment(final TestDestinationEnv environment) throws Exception { + environmentVariables.set("DEPLOYMENT_MODE", "CLOUD"); + environmentVariables.set(EnvVariableFeatureFlags.USE_STREAM_CAPABLE_STATE, "true"); + super.setupEnvironment(environment); + } + @Override public Path getConfigFilePath() { return Path.of("secrets/ssh-key-repl-config.json"); diff --git a/airbyte-integrations/connectors/source-mysql/src/test-integration/java/io/airbyte/integrations/io/airbyte/integration_tests/sources/SshPasswordMySqlSourceAcceptanceTest.java b/airbyte-integrations/connectors/source-mysql/src/test-integration/java/io/airbyte/integrations/io/airbyte/integration_tests/sources/SshPasswordMySqlSourceAcceptanceTest.java index 647f40dc90a7..c498e9ecd489 100644 --- a/airbyte-integrations/connectors/source-mysql/src/test-integration/java/io/airbyte/integrations/io/airbyte/integration_tests/sources/SshPasswordMySqlSourceAcceptanceTest.java +++ b/airbyte-integrations/connectors/source-mysql/src/test-integration/java/io/airbyte/integrations/io/airbyte/integration_tests/sources/SshPasswordMySqlSourceAcceptanceTest.java @@ -4,10 +4,27 @@ package io.airbyte.integrations.io.airbyte.integration_tests.sources; +import io.airbyte.commons.features.EnvVariableFeatureFlags; +import io.airbyte.integrations.standardtest.source.TestDestinationEnv; import java.nio.file.Path; +import org.junit.jupiter.api.extension.ExtendWith; +import uk.org.webcompere.systemstubs.environment.EnvironmentVariables; +import uk.org.webcompere.systemstubs.jupiter.SystemStub; +import uk.org.webcompere.systemstubs.jupiter.SystemStubsExtension; +@ExtendWith(SystemStubsExtension.class) public class SshPasswordMySqlSourceAcceptanceTest extends AbstractSshMySqlSourceAcceptanceTest { + @SystemStub + private EnvironmentVariables environmentVariables; + + @Override + protected void setupEnvironment(final TestDestinationEnv environment) throws Exception { + environmentVariables.set("DEPLOYMENT_MODE", "CLOUD"); + environmentVariables.set(EnvVariableFeatureFlags.USE_STREAM_CAPABLE_STATE, "true"); + super.setupEnvironment(environment); + } + @Override public Path getConfigFilePath() { return Path.of("secrets/ssh-pwd-repl-config.json"); From fd2cb985e76c5390885f474bd999524d9e6e62a0 Mon Sep 17 00:00:00 2001 From: Akash Kulkarni Date: Mon, 5 Dec 2022 19:54:10 -0800 Subject: [PATCH 2/2] Remove setting cloud --- .../sources/SshKeyMySqlSourceAcceptanceTest.java | 1 - .../sources/SshPasswordMySqlSourceAcceptanceTest.java | 1 - 2 files changed, 2 deletions(-) diff --git a/airbyte-integrations/connectors/source-mysql/src/test-integration/java/io/airbyte/integrations/io/airbyte/integration_tests/sources/SshKeyMySqlSourceAcceptanceTest.java b/airbyte-integrations/connectors/source-mysql/src/test-integration/java/io/airbyte/integrations/io/airbyte/integration_tests/sources/SshKeyMySqlSourceAcceptanceTest.java index dcd33ee86576..b2f950976e31 100644 --- a/airbyte-integrations/connectors/source-mysql/src/test-integration/java/io/airbyte/integrations/io/airbyte/integration_tests/sources/SshKeyMySqlSourceAcceptanceTest.java +++ b/airbyte-integrations/connectors/source-mysql/src/test-integration/java/io/airbyte/integrations/io/airbyte/integration_tests/sources/SshKeyMySqlSourceAcceptanceTest.java @@ -20,7 +20,6 @@ public class SshKeyMySqlSourceAcceptanceTest extends AbstractSshMySqlSourceAccep @Override protected void setupEnvironment(final TestDestinationEnv environment) throws Exception { - environmentVariables.set("DEPLOYMENT_MODE", "CLOUD"); environmentVariables.set(EnvVariableFeatureFlags.USE_STREAM_CAPABLE_STATE, "true"); super.setupEnvironment(environment); } diff --git a/airbyte-integrations/connectors/source-mysql/src/test-integration/java/io/airbyte/integrations/io/airbyte/integration_tests/sources/SshPasswordMySqlSourceAcceptanceTest.java b/airbyte-integrations/connectors/source-mysql/src/test-integration/java/io/airbyte/integrations/io/airbyte/integration_tests/sources/SshPasswordMySqlSourceAcceptanceTest.java index c498e9ecd489..e2386f69645e 100644 --- a/airbyte-integrations/connectors/source-mysql/src/test-integration/java/io/airbyte/integrations/io/airbyte/integration_tests/sources/SshPasswordMySqlSourceAcceptanceTest.java +++ b/airbyte-integrations/connectors/source-mysql/src/test-integration/java/io/airbyte/integrations/io/airbyte/integration_tests/sources/SshPasswordMySqlSourceAcceptanceTest.java @@ -20,7 +20,6 @@ public class SshPasswordMySqlSourceAcceptanceTest extends AbstractSshMySqlSource @Override protected void setupEnvironment(final TestDestinationEnv environment) throws Exception { - environmentVariables.set("DEPLOYMENT_MODE", "CLOUD"); environmentVariables.set(EnvVariableFeatureFlags.USE_STREAM_CAPABLE_STATE, "true"); super.setupEnvironment(environment); }