Skip to content

fix: Introduces back the initial_waiting_seconds option for MSSQL source. - #21348

Merged
Sergio Ropero (sergio-ropero) merged 26 commits into
masterfrom
sergio-ropero/fix/mssql-initial-waiting-seconds
Jan 23, 2023
Merged

fix: Introduces back the initial_waiting_seconds option for MSSQL source.#21348
Sergio Ropero (sergio-ropero) merged 26 commits into
masterfrom
sergio-ropero/fix/mssql-initial-waiting-seconds

Conversation

@sergio-ropero

@sergio-ropero Sergio Ropero (sergio-ropero) commented Jan 12, 2023

Copy link
Copy Markdown
Contributor

What

The option initial_waiting_seconds was removed accidentally on PR #18959.
See issue: #21191

How

Rolling back the initial_waiting_seconds related part on above mentioned PR and adding a value to the expected_spec.json file.

Recommended reading order

N/A

🚨 User Impact 🚨

Users were not able to add a delay when setting a connection between MSSQL and any destination.

UI Changes

Version 0.4.26 (master version)

0 4 26

Version 0.4.27 (dev version)

0 4 27

@CLAassistant

CLAassistant commented Jan 12, 2023

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@github-actions

github-actions Bot commented Jan 12, 2023

Copy link
Copy Markdown
Contributor

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

  • Run integration tests
  • Bump connector or module version
  • Add changelog
  • Publish the new version

✅ Sources (2)

Connector Version Changelog Publish
source-mssql 0.4.28
source-mssql-strict-encrypt 0.4.28 🔵
(ignored)
🔵
(ignored)
  • See "Actionable Items" below for how to resolve warnings and errors.

✅ Destinations (0)

Connector Version Changelog Publish
  • See "Actionable Items" below for how to resolve warnings and errors.

✅ Other Modules (0)

Actionable Items

(click to expand)

Category Status Actionable Item
Version
mismatch
The version of the connector is different from its normal variant. Please bump the version of the connector.

doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.
Changelog
doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.

changelog missing
There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish
not in seed
The connector is not in the seed file (e.g. source_definitions.yaml), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.

diff seed version
The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the /publish command to publish the latest version.

@octavia-squidington-iv Octavia Squidington IV (octavia-squidington-iv) added the area/documentation Improvements or additions to documentation label Jan 12, 2023
@sergio-ropero

Sergio Ropero (sergio-ropero) commented Jan 12, 2023

Copy link
Copy Markdown
Contributor Author

/test connector=connectors/source-mssql

🕑 connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/3905725921
❌ connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/3905725921
🐛 https://gradle.com/s/kaylm2tlzbud6

Build Failed

Test summary info:

Could not find result summary

@subodh1810

Subodh Chaturvedi (subodh1810) commented Jan 16, 2023

Copy link
Copy Markdown
Contributor

/test connector=connectors/source-mssql-strict-encrypt

🕑 connectors/source-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3929845689
❌ connectors/source-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3929845689
🐛 https://gradle.com/s/c42wv6lfemong

Build Failed

Test summary info:

Could not find result summary

@sergio-ropero

Sergio Ropero (sergio-ropero) commented Jan 16, 2023

Copy link
Copy Markdown
Contributor Author

/test connector=connectors/source-mssql-strict-encrypt

🕑 connectors/source-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3931653125
❌ connectors/source-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3931653125
🐛 https://gradle.com/s/wt6jpzxbc3z24

Build Failed

Test summary info:

Could not find result summary

@sergio-ropero

Sergio Ropero (sergio-ropero) commented Jan 17, 2023

Copy link
Copy Markdown
Contributor Author

/test connector=connectors/source-mssql

🕑 connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/3938435769
❌ connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/3938435769
🐛 https://gradle.com/s/nsk46zhh3j43a

Build Failed

Test summary info:

Could not find result summary

@sergio-ropero

Sergio Ropero (sergio-ropero) commented Jan 17, 2023

Copy link
Copy Markdown
Contributor Author

/test connector=connectors/source-mssql-strict-encrypt

🕑 connectors/source-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3942272422
✅ connectors/source-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3942272422
No Python unittests run

Build Passed

Test summary info:

All Passed

@sergio-ropero

Sergio Ropero (sergio-ropero) commented Jan 18, 2023

Copy link
Copy Markdown
Contributor Author

/test connector=connectors/source-mssql

🕑 connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/3948501882
✅ connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/3948501882
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1609    339    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestConnection.test_check: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestDiscovery.test_discover: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestBasicRead.test_read: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestFullRefresh.test_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
================= 14 passed, 5 skipped, 21 warnings in 24.05s ==================

@sergio-ropero

Sergio Ropero (sergio-ropero) commented Jan 18, 2023

Copy link
Copy Markdown
Contributor Author

/publish connector=connectors/source-mssql-strict-encrypt

🕑 Publishing the following connectors:
connectors/source-mssql-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/3949506208


Connector Did it publish? Were definitions generated?
connectors/source-mssql-strict-encrypt

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@sergio-ropero
Sergio Ropero (sergio-ropero) temporarily deployed to more-secrets January 19, 2023 19:01 — with GitHub Actions Inactive
@sergio-ropero
Sergio Ropero (sergio-ropero) temporarily deployed to more-secrets January 19, 2023 19:02 — with GitHub Actions Inactive
@sergio-ropero
Sergio Ropero (sergio-ropero) temporarily deployed to more-secrets January 20, 2023 09:03 — with GitHub Actions Inactive
@sergio-ropero
Sergio Ropero (sergio-ropero) temporarily deployed to more-secrets January 20, 2023 09:04 — with GitHub Actions Inactive
@sergio-ropero
Sergio Ropero (sergio-ropero) temporarily deployed to more-secrets January 20, 2023 09:14 — with GitHub Actions Inactive
@sergio-ropero
Sergio Ropero (sergio-ropero) temporarily deployed to more-secrets January 20, 2023 09:14 — with GitHub Actions Inactive
@sergio-ropero
Sergio Ropero (sergio-ropero) temporarily deployed to more-secrets January 20, 2023 09:55 — with GitHub Actions Inactive
@sergio-ropero
Sergio Ropero (sergio-ropero) temporarily deployed to more-secrets January 20, 2023 09:55 — with GitHub Actions Inactive
@sergio-ropero
Sergio Ropero (sergio-ropero) temporarily deployed to more-secrets January 20, 2023 10:30 — with GitHub Actions Inactive
@sergio-ropero
Sergio Ropero (sergio-ropero) temporarily deployed to more-secrets January 20, 2023 10:30 — with GitHub Actions Inactive
@sergio-ropero
Sergio Ropero (sergio-ropero) temporarily deployed to more-secrets January 20, 2023 10:33 — with GitHub Actions Inactive
@sergio-ropero
Sergio Ropero (sergio-ropero) temporarily deployed to more-secrets January 20, 2023 10:33 — with GitHub Actions Inactive
@sergio-ropero
Sergio Ropero (sergio-ropero) temporarily deployed to more-secrets January 20, 2023 13:40 — with GitHub Actions Inactive
@sergio-ropero
Sergio Ropero (sergio-ropero) temporarily deployed to more-secrets January 20, 2023 13:40 — with GitHub Actions Inactive
@sergio-ropero
Sergio Ropero (sergio-ropero) temporarily deployed to more-secrets January 20, 2023 14:57 — with GitHub Actions Inactive
@sergio-ropero
Sergio Ropero (sergio-ropero) temporarily deployed to more-secrets January 20, 2023 14:57 — with GitHub Actions Inactive
@sergio-ropero
Sergio Ropero (sergio-ropero) temporarily deployed to more-secrets January 23, 2023 11:01 — with GitHub Actions Inactive
@sergio-ropero
Sergio Ropero (sergio-ropero) temporarily deployed to more-secrets January 23, 2023 11:01 — with GitHub Actions Inactive
@sergio-ropero
Sergio Ropero (sergio-ropero) deleted the sergio-ropero/fix/mssql-initial-waiting-seconds branch January 23, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants