feat: Filter out system views out of system namespaces - #22221
Merged
Sergio Ropero (sergio-ropero) merged 7 commits intoFeb 6, 2023
Conversation
Sergio Ropero (sergio-ropero)
temporarily deployed
to
more-secrets
February 1, 2023 17:47 — with
GitHub Actions
Inactive
Sergio Ropero (sergio-ropero)
temporarily deployed
to
more-secrets
February 1, 2023 17:47 — with
GitHub Actions
Inactive
Contributor
Affected Connector ReportNOTE
|
| Connector | Version | Changelog | Publish |
|---|---|---|---|
source-alloydb |
1.0.36 |
✅ | ✅ |
source-alloydb-strict-encrypt |
1.0.36 |
🔵 (ignored) |
🔵 (ignored) |
source-bigquery |
0.2.3 |
✅ | ✅ |
source-clickhouse |
0.1.15 |
✅ | ✅ |
source-clickhouse-strict-encrypt |
0.1.15 |
🔵 (ignored) |
🔵 (ignored) |
source-cockroachdb |
0.1.19 |
✅ | ✅ |
source-cockroachdb-strict-encrypt |
0.1.19 |
🔵 (ignored) |
🔵 (ignored) |
source-db2 |
0.1.17 |
✅ | ✅ |
source-db2-strict-encrypt |
0.1.17 |
🔵 (ignored) |
🔵 (ignored) |
source-dynamodb |
0.1.0 |
✅ | ✅ |
source-jdbc |
0.3.5 |
🔵 (ignored) |
🔵 (ignored) |
source-mongodb-strict-encrypt |
0.1.19 |
🔵 (ignored) |
🔵 (ignored) |
source-mongodb-v2 |
0.1.19 |
✅ | ✅ |
source-mssql |
0.4.28 |
✅ | ✅ |
source-mssql-strict-encrypt |
0.4.28 |
🔵 (ignored) |
🔵 (ignored) |
source-mysql |
1.0.21 |
✅ | ✅ |
source-mysql-strict-encrypt |
1.0.21 |
🔵 (ignored) |
🔵 (ignored) |
source-oracle |
0.3.22 |
✅ | ✅ |
source-oracle-strict-encrypt |
0.3.22 |
🔵 (ignored) |
🔵 (ignored) |
source-postgres |
1.0.43 |
✅ | ✅ |
source-postgres-strict-encrypt |
1.0.43 |
🔵 (ignored) |
🔵 (ignored) |
source-redshift |
0.3.16 |
✅ | ✅ |
source-scaffold-java-jdbc |
0.1.0 |
🔵 (ignored) |
🔵 (ignored) |
source-snowflake |
0.1.29 |
✅ | ✅ |
source-tidb |
0.2.2 |
✅ | ✅ |
- See "Actionable Items" below for how to resolve warnings and errors.
✅ Destinations (0)
| Connector | Version | Changelog | Publish |
|---|
- See "Actionable Items" below for how to resolve warnings and errors.
✅ Other Modules (0)
Actionable Items
(click to expand)
| Category | Status | Actionable Item |
|---|---|---|
| Version | ❌ mismatch |
The version of the connector is different from its normal variant. Please bump the version of the connector. |
| ⚠ doc not found |
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug. |
|
| Changelog | ⚠ doc not found |
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug. |
| ❌ changelog missing |
There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog. | |
| Publish | ⚠ not in seed |
The connector is not in the seed file (e.g. source_definitions.yaml), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug. |
| ❌ diff seed version |
The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the /publish command to publish the latest version. |
Sergio Ropero (sergio-ropero)
temporarily deployed
to
more-secrets
February 1, 2023 17:49 — with
GitHub Actions
Inactive
Sergio Ropero (sergio-ropero)
temporarily deployed
to
more-secrets
February 1, 2023 17:49 — with
GitHub Actions
Inactive
Contributor
Airbyte Code Coverage
|
Contributor
Sergio Ropero (sergio-ropero)
marked this pull request as ready for review
February 2, 2023 14:04
Sergio Ropero (sergio-ropero)
temporarily deployed
to
more-secrets
February 2, 2023 14:06 — with
GitHub Actions
Inactive
Sergio Ropero (sergio-ropero)
temporarily deployed
to
more-secrets
February 2, 2023 14:06 — with
GitHub Actions
Inactive
added 2 commits
February 2, 2023 15:20
…es' into feat/exclude-system-views-postgres
Contributor
Author
|
/test connector=connectors/source-postgres
Build PassedTest summary info: |
Contributor
Author
|
/test connector=connectors/source-postgres-strict-encrypt
Build PassedTest summary info: |
Sergio Ropero (sergio-ropero)
temporarily deployed
to
more-secrets
February 2, 2023 14:22 — with
GitHub Actions
Inactive
Sergio Ropero (sergio-ropero)
temporarily deployed
to
more-secrets
February 2, 2023 14:23 — with
GitHub Actions
Inactive
Subodh Chaturvedi (subodh1810)
approved these changes
Feb 6, 2023
Sergio Ropero (sergio-ropero)
temporarily deployed
to
more-secrets
February 6, 2023 17:17 — with
GitHub Actions
Inactive
Sergio Ropero (sergio-ropero)
temporarily deployed
to
more-secrets
February 6, 2023 17:17 — with
GitHub Actions
Inactive
Sergio Ropero (sergio-ropero)
temporarily deployed
to
more-secrets
February 6, 2023 17:31 — with
GitHub Actions
Inactive
Sergio Ropero (sergio-ropero)
temporarily deployed
to
more-secrets
February 6, 2023 17:31 — with
GitHub Actions
Inactive
Sergio Ropero (sergio-ropero)
deleted the
feat/exclude-system-views-postgres
branch
February 6, 2023 18:10
Sergio Ropero (sergio-ropero)
restored the
feat/exclude-system-views-postgres
branch
February 6, 2023 18:22
Sergio Ropero (sergio-ropero)
added a commit
that referenced
this pull request
Feb 6, 2023
This reverts commit 3bf87a9.
Subodh Chaturvedi (subodh1810)
pushed a commit
that referenced
this pull request
Feb 6, 2023
This was referenced Feb 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes allows to filter out system views created out of system namespaces.
Issue: #1323
As the only impacted DB is Postgres, we will bump only that image.
TEST
Current version (1.0.42)
PR version (dev)