Destination-BigQuery: fixed table already exists error by etsybaev · Pull Request #22497 · airbytehq/airbyte

Eugene (etsybaev) · 2023-02-07T15:53:51Z

What

Currently, Destination BigQuery will call the method createTableIfNotExist, however, there's no check for whether the table with the associated tableId exists before attempting to create the table. This results in connectors using BigQuery staging to see errors that a table "ALREADY EXISTS" despite not seeing this message in the past

How

Added verification of table already exists.

🚨 User Impact 🚨

No breaking changes expected

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Eugene (etsybaev) · 2023-02-07T15:54:50Z

/test connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/4115731520
✅ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/4115731520
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 15      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    15      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     171      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         194     48    75%
normalization/transform_catalog/utils.py                             51     14    73%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         65     39    40%
normalization/transform_catalog/stream_processor.py                 595    400    33%
-------------------------------------------------------------------------------------
TOTAL                                                              1457    630    57%

Build Passed

Test summary info:

All Passed

github-actions · 2023-02-07T15:56:52Z

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

Run integration tests
Bump connector or module version
Add changelog
Publish the new version

✅ Sources (0)

Connector	Version	Changelog	Publish

See "Actionable Items" below for how to resolve warnings and errors.

✅ Destinations (2)

Connector	Version	Changelog	Publish
`destination-bigquery`	`1.2.14`	✅	✅
`destination-bigquery-denormalized`	`1.2.14`	✅	✅

See "Actionable Items" below for how to resolve warnings and errors.

👀 Other Modules (1)

base-normalization

Actionable Items

(click to expand)

Category	Status	Actionable Item
Version	❌ mismatch	The version of the connector is different from its normal variant. Please bump the version of the connector.
	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
Changelog	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
	❌ changelog missing	There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish	⚠ not in seed	The connector is not in the seed file (e.g. `source_definitions.yaml`), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.
	❌ diff seed version	The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the `/publish` command to publish the latest version.

Eugene (etsybaev) · 2023-02-07T21:09:21Z

/test connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/4118248883
❌ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/4118248883
🐛

Build Passed

Test summary info:

All Passed

…table-already-exists-err

Eugene (etsybaev) · 2023-02-08T13:36:07Z

/test connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/4124678796
❌ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/4124678796
🐛

Build Passed

Test summary info:

All Passed

…table-already-exists-err

Eugene (etsybaev) · 2023-02-08T15:14:55Z

/test connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/4125568719
❌ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/4125568719
🐛

Build Passed

Test summary info:

All Passed

…table-already-exists-err

Eugene (etsybaev) · 2023-02-08T18:50:54Z

/test connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/4127412287
❌ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/4127412287
🐛

Build Passed

Test summary info:

All Passed

Eugene (etsybaev) · 2023-02-08T21:33:20Z

/test connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/4128594277
❌ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/4128594277
🐛

Build Passed

Test summary info:

All Passed

Greg Solovyev (grishick) · 2023-02-09T00:06:46Z

Eugene (@etsybaev) looks like /test is failing because QA checks require changelog to be updated. Can you bump connector version in Dockerfile, add changelog and re-run /test ?

Eugene (etsybaev) · 2023-02-09T09:16:53Z

/test connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/4132721240
❌ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/4132721240
🐛

Build Passed

Test summary info:

All Passed

Eugene (etsybaev) · 2023-02-09T11:00:41Z

/test connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/4133559316
❌ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/4133559316
🐛

Build Passed

Test summary info:

All Passed

Eugene (etsybaev) · 2023-02-09T12:05:36Z

/test connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/4134050125
✅ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/4134050125
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 15      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    15      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     171      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         194     48    75%
normalization/transform_catalog/utils.py                             51     14    73%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         65     39    40%
normalization/transform_catalog/stream_processor.py                 595    400    33%
-------------------------------------------------------------------------------------
TOTAL                                                              1457    630    57%

Build Passed

Test summary info:

All Passed

Eugene (etsybaev) · 2023-02-09T13:05:21Z

/publish connector=connectors/destination-bigquery

🕑 Publishing the following connectors:
connectors/destination-bigquery
https://github.com/airbytehq/airbyte/actions/runs/4134535308

Connector	Did it publish?	Were definitions generated?
connectors/destination-bigquery	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

github-actions · 2023-02-09T14:06:09Z

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage	24.66%	❌

Eugene (etsybaev) · 2023-02-09T14:16:01Z

/publish connector=connectors/destination-bigquery-denormalized

🕑 Publishing the following connectors:
connectors/destination-bigquery-denormalized
https://github.com/airbytehq/airbyte/actions/runs/4135148730

Connector	Did it publish?	Were definitions generated?
connectors/destination-bigquery-denormalized	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

…table-already-exists-err

[22178] Destination-bigquery: fixed table already exists error

6401a9f

Octavia Squidington III (octavia-squidington-iii) added area/connectors Connector related issues connectors/destination/bigquery labels Feb 7, 2023

Eugene (etsybaev) linked an issue Feb 7, 2023 that may be closed by this pull request

Destination BigQuery: createTableIfNotExists does not check if table exists prior to creating table #22178

Closed

Eugene (etsybaev) marked this pull request as ready for review February 7, 2023 18:03

Eugene (etsybaev) requested a review from a team as a code owner February 7, 2023 18:03

Greg Solovyev (grishick) approved these changes Feb 7, 2023

View reviewed changes

Merge branch 'master' into etsybaev/22178-destination-bigquery-fixed-…

42452ac

…table-already-exists-err

Eugene (etsybaev) added 2 commits February 8, 2023 17:12

Merge branch 'master' into etsybaev/22178-destination-bigquery-fixed-…

20cebbe

…table-already-exists-err

added changelog

f87bed7

Octavia Squidington III (octavia-squidington-iii) added the area/documentation Improvements or additions to documentation label Feb 8, 2023

Merge branch 'master' into etsybaev/22178-destination-bigquery-fixed-…

c95e77e

…table-already-exists-err

aligned version for bigquery denormalized

2dd013c

Octavia Squidington III (octavia-squidington-iii) added the connectors/destination/bigquery-denormalized label Feb 8, 2023

reverted bumping version

d502d64

bumped version

43c76e7

updated changelog

de5a613

updated changelog (one more time)

7ef3960

auto-bump connector version

a26cf70

Octavia Squidington III (octavia-squidington-iii) added the normalization label Feb 9, 2023

Airbyte (airbyteio) temporarily deployed to more-secrets February 9, 2023 13:59 — with GitHub Actions Inactive

auto-bump connector version

8b0acb2

Airbyte (airbyteio) temporarily deployed to more-secrets February 9, 2023 14:53 — with GitHub Actions Inactive

Eugene (etsybaev) enabled auto-merge (squash) February 9, 2023 15:18

Merge branch 'master' into etsybaev/22178-destination-bigquery-fixed-…

51de79c

…table-already-exists-err

Octavia Squidington III (octavia-squidington-iii) removed the normalization label Feb 9, 2023

Eugene (etsybaev) temporarily deployed to more-secrets February 9, 2023 16:11 — with GitHub Actions Inactive

Eugene (etsybaev) merged commit a70d6e8 into master Feb 9, 2023

Eugene (etsybaev) deleted the etsybaev/22178-destination-bigquery-fixed-table-already-exists-err branch February 9, 2023 16:49

github-actions Bot mentioned this pull request Feb 9, 2023

Bump helm chart version reference to 0.43.34 #22684

Closed

This was referenced Feb 10, 2023

Bump Airbyte version from 0.40.32 to 0.40.33 #22689

Closed

Bump Airbyte version from 0.40.32 to 0.40.33 #22839

Closed

Conversation

Eugene (etsybaev) commented Feb 7, 2023

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Uh oh!

Eugene (etsybaev) commented Feb 7, 2023 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Build Passed

Uh oh!

github-actions Bot commented Feb 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Affected Connector Report

✅ Sources (0)

✅ Destinations (2)

👀 Other Modules (1)

Actionable Items

Uh oh!

Eugene (etsybaev) commented Feb 7, 2023 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Build Passed

Uh oh!

Eugene (etsybaev) commented Feb 8, 2023 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Build Passed

Uh oh!

Eugene (etsybaev) commented Feb 8, 2023 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Build Passed

Uh oh!

Eugene (etsybaev) commented Feb 8, 2023 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Build Passed

Uh oh!

Eugene (etsybaev) commented Feb 8, 2023 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Build Passed

Uh oh!

Greg Solovyev (grishick) commented Feb 9, 2023

Uh oh!

Eugene (etsybaev) commented Feb 9, 2023 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Build Passed

Uh oh!

Eugene (etsybaev) commented Feb 9, 2023 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Build Passed

Uh oh!

Eugene (etsybaev) commented Feb 9, 2023 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Build Passed

Uh oh!

Eugene (etsybaev) commented Feb 9, 2023 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Feb 9, 2023

Airbyte Code Coverage

Uh oh!

Eugene (etsybaev) commented Feb 9, 2023 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Eugene (etsybaev) commented Feb 7, 2023 •

edited by github-actions Bot

Loading

github-actions Bot commented Feb 7, 2023 •

edited

Loading

Eugene (etsybaev) commented Feb 7, 2023 •

edited by github-actions Bot

Loading

Eugene (etsybaev) commented Feb 8, 2023 •

edited by github-actions Bot

Loading

Eugene (etsybaev) commented Feb 8, 2023 •

edited by github-actions Bot

Loading

Eugene (etsybaev) commented Feb 8, 2023 •

edited by github-actions Bot

Loading

Eugene (etsybaev) commented Feb 8, 2023 •

edited by github-actions Bot

Loading

Eugene (etsybaev) commented Feb 9, 2023 •

edited by github-actions Bot

Loading

Eugene (etsybaev) commented Feb 9, 2023 •

edited by github-actions Bot

Loading

Eugene (etsybaev) commented Feb 9, 2023 •

edited by github-actions Bot

Loading

Eugene (etsybaev) commented Feb 9, 2023 •

edited by github-actions Bot

Loading

Eugene (etsybaev) commented Feb 9, 2023 •

edited by github-actions Bot

Loading