Set ssl_mode to require on remaining strict encrypt db sources - #24529
Conversation
Affected Connector ReportNOTE
|
| Connector | Version | Changelog | Publish |
|---|---|---|---|
source-alloydb |
2.0.10 |
✅ | ✅ |
source-alloydb-strict-encrypt |
2.0.10 |
🔵 (ignored) |
🔵 (ignored) |
source-mysql |
2.0.9 |
✅ | ✅ |
source-mysql-strict-encrypt |
2.0.9 |
🔵 (ignored) |
🔵 (ignored) |
source-postgres-strict-encrypt |
2.0.11 |
🔵 (ignored) |
🔵 (ignored) |
- See "Actionable Items" below for how to resolve warnings and errors.
✅ Destinations (0)
| Connector | Version | Changelog | Publish |
|---|
- See "Actionable Items" below for how to resolve warnings and errors.
✅ Other Modules (0)
Actionable Items
(click to expand)
| Category | Status | Actionable Item |
|---|---|---|
| Version | ❌ mismatch |
The version of the connector is different from its normal variant. Please bump the version of the connector. |
| ⚠ doc not found |
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug. |
|
| Changelog | ⚠ doc not found |
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug. |
| ❌ changelog missing |
There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog. | |
| Publish | ⚠ not in seed |
The connector is not in the seed file (e.g. source_definitions.yaml), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug. |
| ❌ diff seed version |
The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the /publish command to publish the latest version. |
|
/test connector=connectors/source-alloydb
Build PassedTest summary info: |
|
/test connector=connectors/source-alloydb-strict-encrypt
Build PassedTest summary info: |
|
/test connector=connectors/source-mysql
Build PassedTest summary info: |
|
/test connector=connectors/source-mysql-strict-encrypt
Build FailedTest summary info: |
|
/test connector=connectors/source-mysql-strict-encrypt
Build PassedTest summary info: |
|
/test connector=connectors/source-postgres
Build PassedTest summary info: |
|
/publish connector=connectors/source-alloydb
if you have connectors that successfully published but failed definition generation, follow step 4 here |
|
/publish connector=connectors/source-alloydb-strict-encrypt
if you have connectors that successfully published but failed definition generation, follow step 4 here |
|
/publish connector=connectors/source-mysql
if you have connectors that successfully published but failed definition generation, follow step 4 here |
|
/publish connector=connectors/source-mysql-strict-encrypt
if you have connectors that successfully published but failed definition generation, follow step 4 here |
What
Similar to #24446, this PR sets the SSL Mode field to required on the remaining strict encrypt db sources that have that field.
How
Set the SSL Mode
defaultfield torequire/requiredin the strict encrypt classes' modifySpec method.Note: to update alloydb, I had to modify the PostgresStrictEncryptSource file in the
source-postgresdirectory, since that is what AlloyDb strict encrypt is currently pulling from.This update was not made in the above linked PR, because there are currently two PostgresStrictEncryptSource files: one in the source-postgres folder which is only used for integration tests and for the alloydb strict encrypt connector, and one in the source-postgres-strict-encrypt folder which is actually the one used to build the postgres strict encrypt docker image (and that is the one I updated in the above linked PR).
These duplicate files should be consolidated, as discussed on slack here and captured in this issue