Skip to content

Revert "Better formatting/logging for pre-sync data" - #25560

Merged
Octavia The Approver (octavia-approvington) merged 3 commits into
masterfrom
revert-25459-moar_logging
Apr 26, 2023
Merged

Octavia The Approver (octavia-approvington) merged 3 commits into
masterfrom
revert-25459-moar_logging

Conversation

@akashkulk

Copy link
Copy Markdown
Contributor

Reverts #25459

@github-actions

github-actions Bot commented Apr 26, 2023 •

Copy link
Copy Markdown
Contributor

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

  • Run integration tests
  • Bump connector or module version
  • Add changelog
  • Publish the new version

✅ Sources (22)

Connector Version Changelog Publish
source-alloydb 2.0.23 ✅ ✅
source-alloydb-strict-encrypt 2.0.23 🔵
(ignored)
🔵
(ignored)
source-bigquery 0.2.3 ✅ ✅
source-clickhouse 0.1.17 ✅ ✅
source-clickhouse-strict-encrypt 0.1.17 🔵
(ignored)
🔵
(ignored)
source-cockroachdb 0.1.22 ✅ ✅
source-cockroachdb-strict-encrypt 0.1.22 🔵
(ignored)
🔵
(ignored)
source-db2 0.1.19 ✅ ✅
source-db2-strict-encrypt 0.1.19 🔵
(ignored)
🔵
(ignored)
source-mssql 1.0.14 ✅ ✅
source-mssql-strict-encrypt 1.0.14 🔵
(ignored)
🔵
(ignored)
source-mysql 2.0.18 ✅ ✅
source-mysql-strict-encrypt 2.0.18 🔵
(ignored)
🔵
(ignored)
source-oracle 0.3.24 ✅ ✅
source-oracle-strict-encrypt 0.3.24 🔵
(ignored)
🔵
(ignored)
source-postgres 2.0.26 ✅ ✅
source-postgres-strict-encrypt 2.0.26 🔵
(ignored)
🔵
(ignored)
source-redshift 0.3.16 ✅ ✅
source-scaffold-java-jdbc 0.1.0 🔵
(ignored)
🔵
(ignored)
source-snowflake 0.1.34 ✅ ✅
source-teradata 0.1.0 ✅ ✅
source-tidb 0.2.4 ✅ ✅
  • See "Actionable Items" below for how to resolve warnings and errors.

✅ Destinations (0)

Connector Version Changelog Publish
  • See "Actionable Items" below for how to resolve warnings and errors.

✅ Other Modules (0)

Actionable Items

(click to expand)

Category Status Actionable Item
Version ❌
mismatch
The version of the connector is different from its normal variant. Please bump the version of the connector.
⚠
doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.
Changelog ⚠
doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.
❌
changelog missing
There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish ⚠
not in seed
The connector is not in the seed file (e.g. source_definitions.yaml), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.
❌
diff seed version
The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the /publish command to publish the latest version.

@akashkulk

Akash Kulkarni (akashkulk) commented Apr 26, 2023 •

Copy link
Copy Markdown
Contributor Author

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/4810489443
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/4810489443
No Python unittests run

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
=================== 68 passed, 5 skipped in 84.62s (0:01:24) ===================

@akashkulk

Akash Kulkarni (akashkulk) commented Apr 26, 2023 •

Copy link
Copy Markdown
Contributor Author

/publish connector=connectors/source-postgres run-tests=false

🕑 Publishing the following connectors:
connectors/source-postgres
https://github.com/airbytehq/airbyte/actions/runs/4810902899


Connector Version Did it publish? Were definitions generated?
connectors/source-postgres 2.0.26 ✅ ✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@akashkulk

Akash Kulkarni (akashkulk) commented Apr 26, 2023 •

Copy link
Copy Markdown
Contributor Author

/publish connector=connectors/source-postgres-strict-encrypt run-tests=false

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@akashkulk

Akash Kulkarni (akashkulk) commented Apr 26, 2023 •

Copy link
Copy Markdown
Contributor Author

/publish connector=connectors/source-postgres-strict-encrypt run-tests=false

🕑 Publishing the following connectors:
connectors/source-postgres-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/4811152145


Connector Version Did it publish? Were definitions generated?
connectors/source-postgres-strict-encrypt 2.0.26 ✅ ❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@akashkulk

Copy link
Copy Markdown
Contributor Author

/approve-and-merge reason="Revert of previous change only"

@octavia-approvington

Copy link
Copy Markdown
Contributor

This is really good
simply the best

@octavia-approvington
Octavia The Approver (octavia-approvington) deleted the revert-25459-moar_logging branch April 26, 2023 18:16
M. Marx (marcosmarxm) pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
* Revert "Better formatting/logging for pre-sync data (airbytehq#25459)"

This reverts commit 0d9b7b4.

* Fix dockerfile + docs

* auto-bump connector version

---------

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants