Replicate recent dockerfile changes into dagger #25653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbfbell
approved these changes
Apr 28, 2023
edgao
commented
Apr 28, 2023
tools/ci_connector_ops/ci_connector_ops/pipelines/actions/environments.py
Outdated
Show resolved
Hide resolved
alafanechere
approved these changes
May 3, 2023
tools/ci_connector_ops/ci_connector_ops/pipelines/actions/environments.py
Outdated
Show resolved
Hide resolved
tools/ci_connector_ops/ci_connector_ops/pipelines/actions/environments.py
Outdated
Show resolved
Hide resolved
marcosmarxm
pushed a commit
to natalia-miinto/airbyte
that referenced
this pull request
Jun 8, 2023
* replicate dockerfile changes * only add normalization stuff if needed * also set entrypoint >.> * fix order of constants * clean up normalization mappings + fail loudly * manually install urllib3 1.26.15 * fix declaration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #25492; relates to #25506
changes sourced from: https://github.com/airbytehq/airbyte/pull/25097/files#diff-ef927a1bde217f45489a1408ed303e9783225cc41482a42db0c13403b7f2b4be + https://github.com/airbytehq/airbyte/pull/25588/files
I ran local syncs with destinations bigquery and postgres, which both behaved as expected. (i.e. normalization ran successfully in bigquery, and postgres didn't try to do anything with normalizatoin)