Skip to content

Source S3: fix start date - #27611

Merged
Artem Inzhyyants (artem1205) merged 3 commits into
masterfrom
artem1205/source-s3-OC-2251
Jun 22, 2023
Merged

Artem Inzhyyants (artem1205) merged 3 commits into
masterfrom
artem1205/source-s3-OC-2251

Conversation

@artem1205

Copy link
Copy Markdown
Contributor

What

Resolve https://github.com/airbytehq/oncall/issues/2251

How

fix config path to start_date

Recommended reading order

  1. y.python

🚨 User Impact 🚨

no breaking changes

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

@github-actions

github-actions Bot commented Jun 22, 2023 •

Copy link
Copy Markdown
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • The connector tests are passing in CI
  • You've updated the connector's metadata.yaml file (new!)
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@artem1205
Artem Inzhyyants (artem1205) marked this pull request as ready for review June 22, 2023 14:08
@octavia-squidington-iii Octavia Squidington III (octavia-squidington-iii) added the area/documentation Improvements or additions to documentation label Jun 22, 2023
@octavia-squidington-iii

Copy link
Copy Markdown
Collaborator

source-s3 test report (commit d96d541e33) - ❌

⏲️ Total pipeline duration: 1249 seconds

Step Result
Validate airbyte-integrations/connectors/source-s3/metadata.yaml ✅
Connector version semver check. ✅
Connector version increment check. ❌
QA checks ✅
Code format checks ✅
Connector package install ✅
Build source-s3 docker image for platform linux/x86_64 ✅
Unit tests ✅
Integration tests ✅
Acceptance tests ✅

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-s3 test

@octavia-squidington-iii

Copy link
Copy Markdown
Collaborator

source-s3 test report (commit d96d541e33) - ❌

⏲️ Total pipeline duration: 935 seconds

Step Result
Validate airbyte-integrations/connectors/source-s3/metadata.yaml ✅
Connector version semver check. ✅
Connector version increment check. ❌
QA checks ✅
Code format checks ✅
Connector package install ✅
Build source-s3 docker image for platform linux/x86_64 ✅
Unit tests ✅
Integration tests ✅
Acceptance tests ✅

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-s3 test

@octavia-squidington-iii

Copy link
Copy Markdown
Collaborator

source-s3 test report (commit c5e5320643) - ✅

⏲️ Total pipeline duration: 951 seconds

Step Result
Validate airbyte-integrations/connectors/source-s3/metadata.yaml ✅
Connector version semver check. ✅
Connector version increment check. ✅
QA checks ✅
Code format checks ✅
Connector package install ✅
Build source-s3 docker image for platform linux/x86_64 ✅
Unit tests ✅
Integration tests ✅
Acceptance tests ✅

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-s3 test

@artem1205
Artem Inzhyyants (artem1205) deleted the artem1205/source-s3-OC-2251 branch June 22, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/s3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants