Skip to content

Source S3: handle Bucket Access Errors - #27651

Merged
Artem Inzhyyants (artem1205) merged 2 commits into
masterfrom
artem1205/source-s3-OC-2217
Jun 23, 2023
Merged

Source S3: handle Bucket Access Errors#27651
Artem Inzhyyants (artem1205) merged 2 commits into
masterfrom
artem1205/source-s3-OC-2217

Conversation

@artem1205

Copy link
Copy Markdown
Contributor

What

Resolve https://github.com/airbytehq/oncall/issues/2217

How

Handle bucket errors (e.g. No bucket, wrong credentials)

Recommended reading order

  1. y.python

🚨 User Impact 🚨

no breaking changes

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

@github-actions

github-actions Bot commented Jun 23, 2023

Copy link
Copy Markdown
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • The connector tests are passing in CI
  • You've updated the connector's metadata.yaml file (new!)
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii

Copy link
Copy Markdown
Collaborator

source-s3 test report (commit c48924943f) - ✅

⏲️ Total pipeline duration: 1000 seconds

Step Result
Validate airbyte-integrations/connectors/source-s3/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Code format checks
Connector package install
Build source-s3 docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-s3 test

@octavia-squidington-iii

Copy link
Copy Markdown
Collaborator

source-s3 test report (commit c48924943f) - ✅

⏲️ Total pipeline duration: 906 seconds

Step Result
Validate airbyte-integrations/connectors/source-s3/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Code format checks
Connector package install
Build source-s3 docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-s3 test

@artem1205
Artem Inzhyyants (artem1205) deleted the artem1205/source-s3-OC-2217 branch June 23, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/s3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants