Skip to content

set source defined cursor field for cdc - #2878

Merged
Charles (cgardens) merged 3 commits into
masterfrom
cgardens/cdc_uses_source_defined
Apr 21, 2021
Merged

set source defined cursor field for cdc#2878
Charles (cgardens) merged 3 commits into
masterfrom
cgardens/cdc_uses_source_defined

Conversation

@cgardens

@cgardens Charles (cgardens) commented Apr 13, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

relates to #2837

What

  • Users should not be able to set a cursor field on cdc sources. This is part 1 of 2. Part 2 is for the UI to not allow users to do this if source defined is true.

michel-tricot
Michel Tricot (michel-tricot) reviewed Apr 13, 2021
View reviewed changes

@michel-tricot Michel Tricot (michel-tricot) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cgardens
Charles (cgardens) force-pushed the cgardens/cdc_uses_source_defined branch from 75ca914 to 4840754 Compare April 19, 2021 16:57
@cgardens

Charles (cgardens) commented Apr 19, 2021 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/publish connector=connectors/source-posgres

🕑 connectors/source-posgres https://github.com/airbytehq/airbyte/actions/runs/764337144
❌ connectors/source-posgres https://github.com/airbytehq/airbyte/actions/runs/764337144

@cgardens

Charles (cgardens) commented Apr 19, 2021 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/publish connector=source-posgres

❌ source-posgres https://github.com/airbytehq/airbyte/actions/runs/764366589

@cgardens

Charles (cgardens) commented Apr 19, 2021 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/publish connector=source-postgres

❌ source-postgres https://github.com/airbytehq/airbyte/actions/runs/764381686

@cgardens

Charles (cgardens) commented Apr 19, 2021 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/publish connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/764382865
❌ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/764382865

@cgardens

Charles (cgardens) commented Apr 19, 2021 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/test connector=source-postgres

🕑 source-postgres https://github.com/airbytehq/airbyte/actions/runs/764388791
❌ source-postgres https://github.com/airbytehq/airbyte/actions/runs/764388791

@cgardens

Charles (cgardens) commented Apr 19, 2021 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/764389042
❌ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/764389042

@cgardens
Charles (cgardens) force-pushed the cgardens/cdc_uses_source_defined branch from d78e857 to 1ae7a4e Compare April 21, 2021 17:33
@cgardens

Charles (cgardens) commented Apr 21, 2021 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/publish connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/771640688
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/771640688

@cgardens

Charles (cgardens) commented Apr 21, 2021 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/publish connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/771641654
❌ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/771641654

@cgardens
Charles (cgardens) merged commit e4d227f into master Apr 21, 2021
@cgardens
Charles (cgardens) deleted the cgardens/cdc_uses_source_defined branch April 21, 2021 22:07
@cgardens Charles (cgardens) mentioned this pull request Apr 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michel-tricot Michel Tricot (michel-tricot) michel-tricot left review comments
+2 more reviewers
@jrhizor Jared Rhizor (jrhizor) jrhizor approved these changes
@sherifnada Sherif A. Nada (sherifnada) sherifnada approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cgardens @jrhizor @michel-tricot @sherifnada