Repository navigation
🐛 Destination Snowflake - change typing and deduping error column creation - #29917
Merged
Merged
Conversation
Octavia Squidington III (octavia-squidington-iii)
added
the
area/connectors
Contributor
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
Octavia Squidington III (octavia-squidington-iii)
added
the
area/documentation
Joe Bell (jbfbell)
marked this pull request as ready for review
August 29, 2023 00:30
Edward Gao (edgao)
approved these changes
Aug 29, 2023
Edward Gao (edgao)
left a comment
Edward Gao (edgao)
left a comment
Contributor
There was a problem hiding this comment.
pending CI success
Evan Tahler (evantahler)
approved these changes
Aug 29, 2023
Joe Bell (jbfbell)
changed the title
Joe Bell (jbfbell)
enabled auto-merge (squash)
August 29, 2023 00:39
Contributor
Author
Contributor
|
| Step | Result |
|---|---|
| Java Connector Unit Tests | ✅ |
| Build connector tar | ✅ |
| Build destination-snowflake docker image for platform linux/x86_64 | ✅ |
| Build airbyte/normalization-snowflake:dev | ✅ |
| Java Connector Integration Tests | ✅ |
| Validate airbyte-integrations/connectors/destination-snowflake/metadata.yaml | ✅ |
| Connector version semver check | ✅ |
| Connector version increment check | ✅ |
| QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=destination-snowflake test
Contributor
|
| Step | Result |
|---|---|
| Java Connector Unit Tests | ✅ |
| Build connector tar | ✅ |
| Build destination-snowflake docker image for platform linux/x86_64 | ✅ |
| Build airbyte/normalization-snowflake:dev | ✅ |
| Java Connector Integration Tests | ✅ |
| Validate airbyte-integrations/connectors/destination-snowflake/metadata.yaml | ✅ |
| Connector version semver check | ✅ |
| Connector version increment check | ✅ |
| QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=destination-snowflake test
Harry Touloupas (harrytou)
pushed a commit
to KYVENetwork/airbyte
that referenced
this pull request
Sep 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempting to reduce the complexity of our typing and deduping queries, specifically removing chained
ARRAY_CATcalls in favor ofARRAY_CONSTRUCT_COMPACT. On a small scale (500 rows) the total duration of the query dropped from 938ms to 743ms (~20% faster) but maybe more interesting/relevant is that the SQL compilation time dropped from 476ms (50% of 938ms) to 202ms (27% of 743ms) or roughly 57% faster.