Skip to content

✨ Source S3: ensure parsing errors are consider as config errors to avoid Sentry alerts - #30217

Merged
Maxime Carbonneau-Leclerc (maxi297) merged 2 commits into
masterfrom
oncall-2838/update-source-s3
Sep 6, 2023
Merged

✨ Source S3: ensure parsing errors are consider as config errors to avoid Sentry alerts#30217
Maxime Carbonneau-Leclerc (maxi297) merged 2 commits into
masterfrom
oncall-2838/update-source-s3

Conversation

@maxi297

@maxi297 Maxime Carbonneau-Leclerc (maxi297) commented Sep 6, 2023

Copy link
Copy Markdown
Contributor

Remove unused files and up cdk version to migrate inference error to config errors and avoir sentry alerts

What

There were inference issues that were caused by glob patterns which resolve to no files.

How

Up the CDK version to the one release based on those changes

@github-actions

github-actions Bot commented Sep 6, 2023

Copy link
Copy Markdown
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@maxi297 Maxime Carbonneau-Leclerc (maxi297) changed the title Remove unused files and up cdk version to migrate inference error to … ✨ Source S3: ensure parsing errors are consider as config errors to avoid Sentry alerts Sep 6, 2023
@octavia-squidington-iii Octavia Squidington III (octavia-squidington-iii) added the area/documentation Improvements or additions to documentation label Sep 6, 2023
@github-actions

github-actions Bot commented Sep 6, 2023

Copy link
Copy Markdown
Contributor

source-s3 test report (commit 7351908476) - ❌

⏲️ Total pipeline duration: 09mn34s

Step Result
Connector package install
Build source-s3 docker image for platform linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-s3/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-s3 test

@github-actions

github-actions Bot commented Sep 6, 2023

Copy link
Copy Markdown
Contributor

source-s3 test report (commit c5890068f2) - ✅

⏲️ Total pipeline duration: 08mn53s

Step Result
Connector package install
Build source-s3 docker image for platform linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-s3/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-s3 test

@clnoll Catherine Noll (clnoll) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/s3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants