✨ Source S3: ensure parsing errors are consider as config errors to avoid Sentry alerts - #30217
Conversation
…config errors and avoir sentry alerts
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
|
| Step | Result |
|---|---|
| Connector package install | ✅ |
| Build source-s3 docker image for platform linux/x86_64 | ✅ |
| Unit tests | ✅ |
| Acceptance tests | ✅ |
| Code format checks | ✅ |
| Validate airbyte-integrations/connectors/source-s3/metadata.yaml | ✅ |
| Connector version semver check | ✅ |
| Connector version increment check | ❌ |
| QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-s3 test
|
| Step | Result |
|---|---|
| Connector package install | ✅ |
| Build source-s3 docker image for platform linux/x86_64 | ✅ |
| Unit tests | ✅ |
| Acceptance tests | ✅ |
| Code format checks | ✅ |
| Validate airbyte-integrations/connectors/source-s3/metadata.yaml | ✅ |
| Connector version semver check | ✅ |
| Connector version increment check | ✅ |
| QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-s3 test
Remove unused files and up cdk version to migrate inference error to config errors and avoir sentry alerts
What
There were inference issues that were caused by glob patterns which resolve to no files.
How
Up the CDK version to the one release based on those changes