DV2: Better errors in the UI - #30491
Merged
Merged
Conversation
Octavia Squidington III (octavia-squidington-iii)
added
area/connectors
Contributor
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
Octavia Squidington III (octavia-squidington-iii)
added
the
area/documentation
Edward Gao (edgao)
changed the title
Edward Gao (edgao)
marked this pull request as ready for review
September 15, 2023 23:31
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Evan Tahler (evantahler)
approved these changes
Sep 16, 2023
Comment on lines
+83
to
+89
| public static <T extends Throwable> void logAllAndThrowFirst(final String initialMessage, final Collection<? extends T> throwables) throws T { | ||
| if (!throwables.isEmpty()) { | ||
| final String stacktraces = throwables.stream().map(ExceptionUtils::getStackTrace).collect(joining("\n")); | ||
| LOGGER.error(initialMessage + stacktraces + "\nRethrowing first exception."); | ||
| throw throwables.iterator().next(); | ||
| } | ||
| } |
Edward Gao (edgao)
enabled auto-merge (squash)
September 18, 2023 15:10
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Octavia Squidington III (octavia-squidington-iii)
added
the
CDK
Contributor
|
| Step | Result |
|---|---|
| Build connector tar | ✅ |
| Build destination-snowflake docker image for platform linux/x86_64 | ✅ |
| Java Connector Unit Tests | ✅ |
| Java Connector Integration Tests | ✅ |
| Validate airbyte-integrations/connectors/destination-snowflake/metadata.yaml | ✅ |
| Connector version semver check | ✅ |
| Connector version increment check | ✅ |
| QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=destination-snowflake test
Contributor
|
| Step | Result |
|---|---|
| Build connector tar | ✅ |
| Build destination-bigquery docker image for platform linux/x86_64 | ✅ |
| Java Connector Unit Tests | ✅ |
| Java Connector Integration Tests | ✅ |
| Validate airbyte-integrations/connectors/destination-bigquery/metadata.yaml | ✅ |
| Connector version semver check | ✅ |
| Connector version increment check | ✅ |
| QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=destination-bigquery test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FutureUtils#reduceExceptionsnow just rethrows the first exception, instead of wrapping them into a bigger exception. Other exceptions are still logged, so we're not completely losing them.job.reload), and also includes execution errors (no idea what these are, but they exist 🤷)example bigquery error:
and snowflake:
This does not solve our sentry grouping problems; see #30502