🐛 source-postgres: fix jsonb[] handling bug by postamar · Pull Request #30534 · airbytehq/airbyte

Marius Posta (postamar) · 2023-09-18T17:09:39Z

This PR fixes #29172 by adding a new subcase for unmatched PostgresTypes in copyToJsonField. This new subcase distinguishes remaining array types from remaining non-array types. Added a unit test to cover.

Fixes #29551.

github-actions · 2023-09-18T17:10:00Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

github-actions · 2023-09-18T17:30:35Z

Coverage report for source-postgres

File	Coverage [60.35%]	❌
PostgresType.java	96.48%	🍏
InitialSyncCtidIterator.java	90.19%	🍏
PostgresSourceOperations.java	32.21%	❌

Total Project Coverage	71.72%	🍏

github-actions · 2023-09-18T17:36:40Z

source-postgres test report (commit `ec6707d904`) - ❌

⏲️ Total pipeline duration: 25mn26s

Step	Result
Build connector tar	✅
Build source-postgres docker image for platform linux/x86_64	✅
Java Connector Unit Tests	✅
Java Connector Integration Tests	✅
Acceptance tests	✅
Validate airbyte-integrations/connectors/source-postgres/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	❌
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-postgres test

github-actions · 2023-09-18T18:02:39Z

source-postgres test report (commit `43cc9c6a8e`) - ✅

⏲️ Total pipeline duration: 23mn39s

Step	Result
Build connector tar	✅
Build source-postgres docker image for platform linux/x86_64	✅
Java Connector Unit Tests	✅
Java Connector Integration Tests	✅
Acceptance tests	✅
Validate airbyte-integrations/connectors/source-postgres/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-postgres test

vercel · 2023-09-25T16:02:44Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 25, 2023 8:49pm

airbyte-oss-build-runner · 2023-09-25T16:34:19Z

source-postgres test report (commit `721bc36f71`) - ❌

⏲️ Total pipeline duration: 26mn57s

Step	Result
Build connector tar	✅
Build source-postgres docker image for platform linux/x86_64	✅
Java Connector Unit Tests	✅
Java Connector Integration Tests	✅
Acceptance tests	✅
Validate airbyte-integrations/connectors/source-postgres/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	❌
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-postgres test

airbyte-oss-build-runner · 2023-09-25T21:15:29Z

source-postgres test report (commit `851f593303`) - ✅

⏲️ Total pipeline duration: 26mn38s

Step	Result
Build connector tar	✅
Build source-postgres docker image for platform linux/x86_64	✅
Java Connector Unit Tests	✅
Java Connector Integration Tests	✅
Acceptance tests	✅
Validate airbyte-integrations/connectors/source-postgres/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-postgres test

Duy Nguyen (nguyenaiden)

This looks good to me! Could you make sure to bump the version in source-postgres-strict-encrypt as well?

Rodi Reich Zilberman (rodireich) · 2023-09-25T23:05:47Z

-            default -> json.put(columnName, value);
+            default -> {
+              if (columnInfo.columnType.isArrayType()) {
+                putArray(json, columnName, resultSet, colIndex);


How come jsonb[] type not falling into case ARRAY ?

Akash Kulkarni (akashkulk) · 2023-09-26T16:10:49Z

+                .withItems(JsonSchemaType.builder(JsonSchemaPrimitive.STRING).build())
+                .build())
+            .addInsertValues("ARRAY['{\"foo\":\"bar\"}'::JSONB, NULL]")
+            .addExpectedValues("[\"{\\\"foo\\\": \\\"bar\\\"}\",null]")


This still seem likes Postgres's string representation of the array. I think we want something along the lines of ["{\"foo\": \"bar\"}"]

As discussed offline, disregard this. It's Java's representation of the array. We've tested this version manually and it fixes the regression 👍

Marius Posta (postamar) requested a review from a team as a code owner September 18, 2023 17:09

Octavia Squidington III (octavia-squidington-iii) added area/connectors Connector related issues connectors/source/postgres labels Sep 18, 2023

Marius Posta (postamar) changed the title ~~source-postgres: fix jsonb[] handling bug~~ 🐛 source-postgres: fix jsonb[] handling bug Sep 18, 2023

Octavia Squidington III (octavia-squidington-iii) added the area/documentation Improvements or additions to documentation label Sep 18, 2023

Marius Posta (postamar) enabled auto-merge (squash) September 18, 2023 19:52

Marius Posta (postamar) force-pushed the postamar/fix-29551 branch from 60b2c4d to 721bc36 Compare September 25, 2023 16:05

vercel Bot deployed to Preview September 25, 2023 16:06 View deployment

Marius Posta (postamar) force-pushed the postamar/fix-29551 branch from 721bc36 to 1935d27 Compare September 25, 2023 20:45

Marius Posta added 3 commits September 25, 2023 16:46

source-postgres: fix jsonb[] column handling in cursor mode

af99e1d

source-postgres: prettier info log output

63f13dc

source-postgres: bump version and update changelog

851f593

Marius Posta (postamar) force-pushed the postamar/fix-29551 branch from 1935d27 to 851f593 Compare September 25, 2023 20:46

vercel Bot deployed to Preview September 25, 2023 20:49 View deployment

Duy Nguyen (nguyenaiden) reviewed Sep 25, 2023

View reviewed changes

Rodi Reich Zilberman (rodireich) reviewed Sep 25, 2023

View reviewed changes

Akash Kulkarni (akashkulk) reviewed Sep 26, 2023

View reviewed changes

Akash Kulkarni (akashkulk) approved these changes Sep 26, 2023

View reviewed changes

Marius Posta (postamar) merged commit 8a22cf9 into master Sep 26, 2023

Marius Posta (postamar) deleted the postamar/fix-29551 branch September 26, 2023 17:00

Navigation Menu

Repository navigation

🐛 source-postgres: fix jsonb[] handling bug - #30534

🐛 source-postgres: fix jsonb[] handling bug#30534
Marius Posta (postamar) merged 3 commits into
masterfrom
postamar/fix-29551

Marius Posta (postamar) commented Sep 18, 2023 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 18, 2023 •

edited by postamar

Loading

Uh oh!

github-actions Bot commented Sep 18, 2023 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 18, 2023

Uh oh!

github-actions Bot commented Sep 18, 2023

Uh oh!

vercel Bot commented Sep 25, 2023 •

edited

Loading

Uh oh!

airbyte-oss-build-runner commented Sep 25, 2023

Uh oh!

airbyte-oss-build-runner commented Sep 25, 2023

Uh oh!

Duy Nguyen (nguyenaiden) left a comment

Uh oh!

Rodi Reich Zilberman (rodireich) Sep 25, 2023

Uh oh!

Akash Kulkarni (akashkulk) Sep 26, 2023

Uh oh!

Akash Kulkarni (akashkulk) Sep 26, 2023

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

Marius Posta (postamar) commented Sep 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 18, 2023 • edited by postamar Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before Merging a Connector Pull Request

Uh oh!

github-actions Bot commented Sep 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage report for source-postgres

Uh oh!

github-actions Bot commented Sep 18, 2023

source-postgres test report (commit ec6707d904) - ❌

Uh oh!

github-actions Bot commented Sep 18, 2023

source-postgres test report (commit 43cc9c6a8e) - ✅

Uh oh!

vercel Bot commented Sep 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

airbyte-oss-build-runner commented Sep 25, 2023

source-postgres test report (commit 721bc36f71) - ❌

Uh oh!

airbyte-oss-build-runner commented Sep 25, 2023

source-postgres test report (commit 851f593303) - ✅

Uh oh!

Duy Nguyen (nguyenaiden) left a comment

Choose a reason for hiding this comment

Uh oh!

Rodi Reich Zilberman (rodireich) Sep 25, 2023

Choose a reason for hiding this comment

Uh oh!

Akash Kulkarni (akashkulk) Sep 26, 2023

Choose a reason for hiding this comment

Uh oh!

Akash Kulkarni (akashkulk) Sep 26, 2023

Choose a reason for hiding this comment

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Marius Posta (postamar) commented Sep 18, 2023 •

edited

Loading

github-actions Bot commented Sep 18, 2023 •

edited by postamar

Loading

github-actions Bot commented Sep 18, 2023 •

edited

Loading

source-postgres test report (commit `ec6707d904`) - ❌

source-postgres test report (commit `43cc9c6a8e`) - ✅

vercel Bot commented Sep 25, 2023 •

edited

Loading

source-postgres test report (commit `721bc36f71`) - ❌

source-postgres test report (commit `851f593303`) - ✅