Skip to content

Destination BigQuery + Snowflake: delete unused constants for reserved keywords - #30592

Merged
Cynthia Yin (cynthiaxyin) merged 2 commits into
masterfrom
cynthia/keywords_cleanup
Sep 19, 2023
Merged

Cynthia Yin (cynthiaxyin) merged 2 commits into
masterfrom
cynthia/keywords_cleanup

Conversation

@cynthiaxyin

Copy link
Copy Markdown
Contributor

closes #30366

@vercel

vercel Bot commented Sep 19, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2023 9:32pm

@github-actions

github-actions Bot commented Sep 19, 2023

Copy link
Copy Markdown
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@github-actions

Copy link
Copy Markdown
Contributor

destination-snowflake test report (commit 67707224e8) - ✅

⏲️ Total pipeline duration: 11mn57s

Step Result
Build connector tar
Build destination-snowflake docker image for platform linux/x86_64
Java Connector Unit Tests
Java Connector Integration Tests
Validate airbyte-integrations/connectors/destination-snowflake/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-snowflake test

@github-actions

Copy link
Copy Markdown
Contributor

destination-bigquery test report (commit 67707224e8) - ✅

⏲️ Total pipeline duration: 06mn15s

Step Result
Build connector tar
Build destination-bigquery docker image for platform linux/x86_64
Java Connector Unit Tests
Java Connector Integration Tests
Validate airbyte-integrations/connectors/destination-bigquery/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-bigquery test

@cynthiaxyin
Cynthia Yin (cynthiaxyin) merged commit bb73ece into master Sep 19, 2023
@cynthiaxyin
Cynthia Yin (cynthiaxyin) deleted the cynthia/keywords_cleanup branch September 19, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Either Quote, mangle, or directly prevent column names with reserved words (All destinations)

3 participants