:tada: Source Facebook Marketing - silver certification tweek by midavadim · Pull Request #30655 · airbytehq/airbyte

midavadim · 2023-09-21T12:01:32Z

What

updated requirement in docs
added default fields for custom insight schema
added SAT for custom insight schema
removed optional spec field - max_batch_size

Fix for:
https://github.com/airbytehq/oncall/issues/3016

🚨 User Impact 🚨

Added default fields for custom insight schema, But this is not a breaking change

Pre-merge Actions

Expand the relevant checklist and delete the others.

New Connector

vercel · 2023-09-21T12:01:37Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 22, 2023 2:33pm

github-actions · 2023-09-21T12:01:57Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

This reverts commit c128690.

…-certification # Conflicts: # airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/streams/streams.py

airbyte-oss-build-runner · 2023-09-21T21:48:50Z

source-facebook-marketing test report (commit `04890be584`) - ❌

⏲️ Total pipeline duration: 01mn13s

Step	Result
Connector package install	✅
Build source-facebook-marketing docker image for platform linux/x86_64	✅
Unit tests	❌
Code format checks	❌
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	❌
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

…est for config without start_date

airbyte-oss-build-runner · 2023-09-21T22:45:21Z

source-facebook-marketing test report (commit `ae3fbc4d0c`) - ❌

⏲️ Total pipeline duration: 53.32s

Step	Result
Connector package install	✅
Build source-facebook-marketing docker image for platform linux/x86_64	✅
Unit tests	❌
Code format checks	❌
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

…-certification

airbyte-oss-build-runner · 2023-09-22T00:58:56Z

source-facebook-marketing test report (commit `eb724639b5`) - ❌

⏲️ Total pipeline duration: 108mn28s

Step	Result
Connector package install	✅
Build source-facebook-marketing docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	❌
Code format checks	❌
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

airbyte-oss-build-runner · 2023-09-22T01:29:47Z

source-facebook-marketing test report (commit `30a9d26104`) - ❌

⏲️ Total pipeline duration: 91mn10s

Step	Result
Connector package install	✅
Build source-facebook-marketing docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	❌
Code format checks	✅
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

…ing-silver-certification' into midavadim/source-facebook-marketing-silver-certification # Conflicts: # airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/streams/base_insight_streams.py

…ing-silver-certification' into midavadim/source-facebook-marketing-silver-certification

Serhii Lazebnyi (lazebnyi)

Please update PR description

airbyte-oss-build-runner · 2023-09-22T11:25:08Z

source-facebook-marketing test report (commit `b183645997`) - ❌

⏲️ Total pipeline duration: 92mn27s

Step	Result
Connector package install	✅
Build source-facebook-marketing docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	❌
Code format checks	✅
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

…-certification

Serhii Lazebnyi (lazebnyi)

Please check comment above

…ing-silver-certification' into midavadim/source-facebook-marketing-silver-certification

midavadim · 2023-09-22T14:18:17Z

Please check comment above

update code to make unique list of fields

Serhii Lazebnyi (lazebnyi)

Please mention in description this issue https://github.com/airbytehq/oncall/issues/3016 if it fixed in this PR. Other good to go after passing tests and small comments.

Co-authored-by: Serhii Lazebnyi <53845333+lazebnyi@users.noreply.github.com>

airbyte-oss-build-runner · 2023-09-22T16:06:52Z

source-facebook-marketing test report (commit `1c6b628efd`) - ✅

⏲️ Total pipeline duration: 93mn23s

Step	Result
Connector package install	✅
Build source-facebook-marketing docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	✅
Code format checks	✅
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

Co-authored-by: midavadim <midavadim@users.noreply.github.com> Co-authored-by: Serhii Lazebnyi <53845333+lazebnyi@users.noreply.github.com>

added check if start_date is specified

39a50fa

Octavia Squidington III (octavia-squidington-iii) added area/connectors Connector related issues connectors/source/facebook-marketing labels Sep 21, 2023

midavadim added 3 commits September 21, 2023 15:07

Revert "updated Prerequisites"

bd8a4c8

This reverts commit c128690.

Merge branch 'master' into midavadim/source-facebook-marketing-silver…

14388f0

…-certification # Conflicts: # airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/streams/streams.py

updated doc, improved schema for custom insight streams

04890be

Octavia Squidington III (octavia-squidington-iii) added the area/documentation Improvements or additions to documentation label Sep 21, 2023

vercel Bot deployed to Preview September 21, 2023 21:46 View deployment

bumper version, added expected record for custom stream, added spec t…

ae3fbc4

…est for config without start_date

midavadim added 3 commits September 22, 2023 01:53

updated docs

24e9036

fixed unit test for custom insight streams

eb72463

Merge branch 'master' into midavadim/source-facebook-marketing-silver…

7a63b5c

…-certification

vercel Bot deployed to Preview September 21, 2023 23:51 View deployment

Automated Commit - Formatting Changes

30a9d26

midavadim requested a review from Serhii Lazebnyi (lazebnyi) September 22, 2023 06:49

midavadim and others added 6 commits September 22, 2023 09:56

fixed SAT

d1e7adc

fixed unittest

4b3801b

Automated Commit - Formatting Changes

1637e79

format

e6de442

Merge remote-tracking branch 'origin/midavadim/source-facebook-market…

dcafbeb

…ing-silver-certification' into midavadim/source-facebook-marketing-silver-certification

Serhii Lazebnyi (lazebnyi) requested changes Sep 22, 2023

View reviewed changes

midavadim added 2 commits September 22, 2023 12:48

removed max_batch_size

22bf78b

updated SAT

b183645

updated expected record

3a463a7

vercel Bot deployed to Preview September 22, 2023 12:34 View deployment

midavadim requested a review from Serhii Lazebnyi (lazebnyi) September 22, 2023 12:51

Merge branch 'master' into midavadim/source-facebook-marketing-silver…

f1e812d

…-certification

vercel Bot deployed to Preview September 22, 2023 12:53 View deployment

Serhii Lazebnyi (lazebnyi) requested changes Sep 22, 2023

View reviewed changes

Comment thread ...nnectors/source-facebook-marketing/source_facebook_marketing/streams/base_insight_streams.py Outdated

midavadim requested a review from Serhii Lazebnyi (lazebnyi) September 22, 2023 13:50

Serhii Lazebnyi (lazebnyi) requested changes Sep 22, 2023

View reviewed changes

midavadim added 2 commits September 22, 2023 17:15

get unique list of custom_fields

14b0067

Merge remote-tracking branch 'origin/midavadim/source-facebook-market…

b835b36

…ing-silver-certification' into midavadim/source-facebook-marketing-silver-certification

vercel Bot deployed to Preview September 22, 2023 14:18 View deployment

midavadim requested a review from Serhii Lazebnyi (lazebnyi) September 22, 2023 14:18

Serhii Lazebnyi (lazebnyi) approved these changes Sep 22, 2023

View reviewed changes

Comment thread docs/integrations/sources/facebook-marketing.md Outdated

Update docs/integrations/sources/facebook-marketing.md

1c6b628

Co-authored-by: Serhii Lazebnyi <53845333+lazebnyi@users.noreply.github.com>

vercel Bot deployed to Preview September 22, 2023 14:33 View deployment

midavadim enabled auto-merge (squash) September 22, 2023 14:53

midavadim merged commit b574fc6 into master Sep 22, 2023

midavadim deleted the midavadim/source-facebook-marketing-silver-certification branch September 22, 2023 16:07

Uh oh!

Conversation

midavadim commented Sep 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

🚨 User Impact 🚨

Pre-merge Actions

Uh oh!

vercel Bot commented Sep 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 21, 2023 • edited by midavadim Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before Merging a Connector Pull Request

Uh oh!

airbyte-oss-build-runner commented Sep 21, 2023

source-facebook-marketing test report (commit 04890be584) - ❌

Uh oh!

airbyte-oss-build-runner commented Sep 21, 2023

source-facebook-marketing test report (commit ae3fbc4d0c) - ❌

Uh oh!

airbyte-oss-build-runner commented Sep 22, 2023

source-facebook-marketing test report (commit eb724639b5) - ❌

Uh oh!

airbyte-oss-build-runner commented Sep 22, 2023

source-facebook-marketing test report (commit 30a9d26104) - ❌

Uh oh!

Serhii Lazebnyi (lazebnyi) left a comment

Choose a reason for hiding this comment

Uh oh!

airbyte-oss-build-runner commented Sep 22, 2023

source-facebook-marketing test report (commit b183645997) - ❌

Uh oh!

Uh oh!

Serhii Lazebnyi (lazebnyi) left a comment

Choose a reason for hiding this comment

Uh oh!

midavadim commented Sep 22, 2023

Uh oh!

Serhii Lazebnyi (lazebnyi) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

airbyte-oss-build-runner commented Sep 22, 2023

source-facebook-marketing test report (commit 1c6b628efd) - ✅

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

midavadim commented Sep 21, 2023 •

edited

Loading

vercel Bot commented Sep 21, 2023 •

edited

Loading

github-actions Bot commented Sep 21, 2023 •

edited by midavadim

Loading

source-facebook-marketing test report (commit `04890be584`) - ❌

source-facebook-marketing test report (commit `ae3fbc4d0c`) - ❌

source-facebook-marketing test report (commit `eb724639b5`) - ❌

source-facebook-marketing test report (commit `30a9d26104`) - ❌

source-facebook-marketing test report (commit `b183645997`) - ❌

source-facebook-marketing test report (commit `1c6b628efd`) - ✅