Skip to content

bump cdk version for postgres, mysql sources - #31322

Merged
Rodi Reich Zilberman (rodireich) merged 6 commits into
masterfrom
30781-bump-cdk-ver
Oct 12, 2023
Merged

Rodi Reich Zilberman (rodireich) merged 6 commits into
masterfrom
30781-bump-cdk-ver

Conversation

@rodireich

@rodireich Rodi Reich Zilberman (rodireich) commented Oct 11, 2023 •

Copy link
Copy Markdown
Contributor

What

Bump the java cdk version to 0.1.8,
And point source postgres and mysql to newly published version, and their respective strict encrypt.
This is to resolve #30781.

How

Bump version, publish cdk,
update connectors build.gradle.

@vercel

vercel Bot commented Oct 11, 2023 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Oct 12, 2023 4:03am

@github-actions

Copy link
Copy Markdown
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@rodireich

Rodi Reich Zilberman (rodireich) commented Oct 11, 2023 •

Copy link
Copy Markdown
Contributor Author

/publish-java-cdk dry-run=true

🕑 https://github.com/airbytehq/airbyte/actions/runs/6488648238
✅ Successfully published Java CDK version=0.1.8!


| Version | Date | Pull Request | Subject |
|:--------|:-----------|:-----------------------------------------------------------|:---------------------------------------------------------------------------------------------------------------------------------------------------------------|
| 0.1.8 | 2023-10-11 | [\#31322](https://github.com/airbytehq/airbyte/pull/31322) | Cap log line length to 32KB to prevent loss of records |

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be updated to the PR that actually introduced the change?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally it would have been the same one. but because of the time that passed I forgot this was in the CDK.
I referred to this one in case someone needs to reconstruct the chain of events and mentioned the issue in description.

@rodireich

Rodi Reich Zilberman (rodireich) commented Oct 11, 2023 •

Copy link
Copy Markdown
Contributor Author

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/6488774423
✅ Successfully published Java CDK version=0.1.8!

@airbyte-oss-build-runner

Copy link
Copy Markdown
Collaborator

source-mysql-strict-encrypt test report (commit 28fbd1d957) - ✅

⏲️ Total pipeline duration: 11mn49s

Step Result
Build connector tar ✅
Build source-mysql-strict-encrypt docker image for platform(s) linux/x86_64 ✅
Java Connector Unit Tests ✅
Java Connector Integration Tests ✅
Acceptance tests ✅
Validate metadata for source-mysql-strict-encrypt ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql-strict-encrypt test

@airbyte-oss-build-runner

Copy link
Copy Markdown
Collaborator

source-postgres-strict-encrypt test report (commit 28fbd1d957) - ✅

⏲️ Total pipeline duration: 08mn03s

Step Result
Build connector tar ✅
Build source-postgres-strict-encrypt docker image for platform(s) linux/x86_64 ✅
Java Connector Unit Tests ✅
Java Connector Integration Tests ✅
Acceptance tests ✅
Validate metadata for source-postgres-strict-encrypt ✅
Connector version semver check ✅
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-postgres-strict-encrypt test

@airbyte-oss-build-runner

Copy link
Copy Markdown
Collaborator

source-mysql test report (commit 28fbd1d957) - ✅

⏲️ Total pipeline duration: 27mn26s

Step Result
Build connector tar ✅
Build source-mysql docker image for platform(s) linux/x86_64 ✅
Java Connector Unit Tests ✅
Java Connector Integration Tests ✅
Acceptance tests ✅
Validate metadata for source-mysql ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql test

@airbyte-oss-build-runner

Copy link
Copy Markdown
Collaborator

source-postgres test report (commit 28fbd1d957) - ❌

⏲️ Total pipeline duration: 26mn48s

Step Result
Build connector tar ✅
Build source-postgres docker image for platform(s) linux/x86_64 ✅
Java Connector Unit Tests ❌
Java Connector Integration Tests ✅
Acceptance tests ✅
Validate metadata for source-postgres ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-postgres test

@airbyte-oss-build-runner

Copy link
Copy Markdown
Collaborator

source-mysql test report (commit 6f700deea9) - ✅

⏲️ Total pipeline duration: 05mn23s

Step Result
Build connector tar ✅
Build source-mysql docker image for platform(s) linux/x86_64 ✅
Java Connector Unit Tests ✅
Java Connector Integration Tests ✅
Acceptance tests ✅
Validate metadata for source-mysql ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql test

@airbyte-oss-build-runner

Copy link
Copy Markdown
Collaborator

source-postgres-strict-encrypt test report (commit 6f700deea9) - ✅

⏲️ Total pipeline duration: 10mn04s

Step Result
Build connector tar ✅
Build source-postgres-strict-encrypt docker image for platform(s) linux/x86_64 ✅
Java Connector Unit Tests ✅
Java Connector Integration Tests ✅
Acceptance tests ✅
Validate metadata for source-postgres-strict-encrypt ✅
Connector version semver check ✅
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-postgres-strict-encrypt test

@airbyte-oss-build-runner

Copy link
Copy Markdown
Collaborator

source-mysql-strict-encrypt test report (commit 6f700deea9) - ✅

⏲️ Total pipeline duration: 03mn18s

Step Result
Build connector tar ✅
Build source-mysql-strict-encrypt docker image for platform(s) linux/x86_64 ✅
Java Connector Unit Tests ✅
Java Connector Integration Tests ✅
Acceptance tests ✅
Validate metadata for source-mysql-strict-encrypt ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql-strict-encrypt test

@github-actions

Copy link
Copy Markdown
Contributor

Coverage report for source-postgres

There is no coverage information present for the Files changed

Total Project Coverage 71.72% 🍏

@airbyte-oss-build-runner

Copy link
Copy Markdown
Collaborator

source-postgres test report (commit 6f700deea9) - ✅

⏲️ Total pipeline duration: 25mn59s

Step Result
Build connector tar ✅
Build source-postgres docker image for platform(s) linux/x86_64 ✅
Java Connector Unit Tests ✅
Java Connector Integration Tests ✅
Acceptance tests ✅
Validate metadata for source-postgres ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-postgres test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Large log message in java connectors can lead to loss of records

5 participants