Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run license check on repo #32154

Merged

Conversation

erohmensing
Copy link
Contributor

@erohmensing erohmensing commented Nov 3, 2023

Run license check - Our old one didn't seem to catch these files. This makes the dependent format command PR actually pass the new CI.

TODO: Replace all the 3-line licenses with 1-line licenses for consistency's sake - that's what the new license checker will add.

Copy link

vercel bot commented Nov 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Nov 3, 2023 7:54pm

Copy link
Contributor

github-actions bot commented Nov 3, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@erohmensing erohmensing marked this pull request as ready for review November 6, 2023 07:27
@erohmensing erohmensing requested a review from a team November 6, 2023 07:27
@erohmensing erohmensing requested a review from a team as a code owner November 6, 2023 07:27
@evantahler
Copy link
Contributor

/approve-and-merge reason="adding license to file headers, no code changes"

@octavia-approvington
Copy link
Contributor

This code is at peace with itself
imagine karate kid approving

@octavia-approvington octavia-approvington merged commit bcee91f into bnchrch/simple-pipeline-context Nov 6, 2023
42 of 61 checks passed
@octavia-approvington octavia-approvington deleted the ella/license-check branch November 6, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants