Repository navigation
Destination BigQuery - remove file_buffer_count - #32234
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
|
Cynthia Yin (@cynthiaxyin) I ran a number of the failing redshift tests locally and they seem to be OK... is this flaky test behavior expected for destination-redshift? Note: to run the DATs locally, you'll need to change |
|
Evan Tahler (@evantahler) Hmm I'm not sure I haven't run destination-redshift tests recently. |
|
Ryan Br... (@tryangul) or Benoit Moriceau (@benmoriceau) - can you confirm that |
|
Evan Tahler (@evantahler) Last I was in this code |
|
Ok, I'm scoping this PR down to be just bigquery changes, as those tests are passing |
The config option
file_buffer_countdoesn't matter now that these destinations have been async'd. Let's remove it!Closes #32275