Repository navigation
π Source S3: Fix discovery for zip file - #32677
Octavia The Approver (octavia-approvington) merged 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! π To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
|
|
||
| def _handle_file(self, file): | ||
| if file["Key"].endswith("zip"): | ||
| if file["Key"].endswith(".zip"): |
There was a problem hiding this comment.
what problem does this solve? did we encounter files ending in zip that did not have an extension?
There was a problem hiding this comment.
Alexandre Girard (@girarda) Yes, the sync failed due to the file without an extension, ending with 'zip'.
Co-authored-by: Alexandre Girard <alexandre@airbyte.io>
|
/approve-and-merge reason="Fixing an oncall issue with the S3 connector to ensure only files with a '.zip' extension are treated as zipped files." |
Co-authored-by: Alexandre Girard <alexandre@airbyte.io>

What
Fix the discovery for zip file. Resolves: https://github.com/airbytehq/oncall/issues/3526
How
Updated the file check to correctly identify files ending with
.zipextension, rather than justzip.