Skip to content

File-based CDK Sources: Hide primary key - #33187

Merged
Catherine Noll (clnoll) merged 4 commits into
masterfrom
fcdk-sources-hide-primary-key
Dec 6, 2023
Merged

Catherine Noll (clnoll) merged 4 commits into
masterfrom
fcdk-sources-hide-primary-key

Conversation

@clnoll

Copy link
Copy Markdown
Contributor

Follow-up to #33172, to bump the CDK version for file-based sources so they hide the primary_key field.

@clnoll
Catherine Noll (clnoll) requested a review from a team December 6, 2023 16:38
@vercel

vercel Bot commented Dec 6, 2023 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2023 5:08pm

@github-actions

github-actions Bot commented Dec 6, 2023 •

Copy link
Copy Markdown
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@clnoll
Catherine Noll (clnoll) merged commit f73827e into master Dec 6, 2023
@clnoll
Catherine Noll (clnoll) deleted the fcdk-sources-hide-primary-key branch December 6, 2023 18:01

This branch was successfully deployed

1 active deployment
Preview — 6336e617 Deployed Dec 6, 2023 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants