airbyte-ci format: exclude .gitignored files from format #33249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
alafanechere
changed the title
This was referenced Dec 8, 2023
postamar
reviewed
Dec 8, 2023
alafanechere
force-pushed
the
augustin/12-08-airbyte-ci_format_exlcude_.gitignored_files_from_format
branch
from
c6cd01c
to
8afd4a8
Compare
alafanechere
changed the base branch from
master
to
augustin/12-11-format-airbyte-ci-init
Base automatically changed from
augustin/12-11-format-airbyte-ci-init
to
master
December 11, 2023 09:59
alafanechere
force-pushed
the
augustin/12-08-airbyte-ci_format_exlcude_.gitignored_files_from_format
branch
from
8afd4a8
to
08c8c32
Compare
alafanechere
changed the base branch from
master
to
augustin/12-11-fix_CDK_format
Closed
alafanechere
force-pushed
the
augustin/12-08-airbyte-ci_format_exlcude_.gitignored_files_from_format
branch
from
08c8c32
to
f658064
Compare
postamar
reviewed
Dec 11, 2023
alafanechere
force-pushed
the
augustin/12-08-airbyte-ci_format_exlcude_.gitignored_files_from_format
branch
from
24c9ceb
to
775f0f2
Compare
alafanechere
changed the base branch from
augustin/12-11-fix_CDK_format
to
master
postamar
requested changes
Dec 11, 2023
airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/format/format_command.py
Outdated
Show resolved
Hide resolved
| # Add all files to the git index | ||
| .with_exec(["git", "add", "."]) | ||
| # Commit all files | ||
| .with_exec(["git", "commit", "--message", "Commit for formatting"]) |
There was a problem hiding this comment.
I don't believe that you need to commit anything for git clean to do its thing, in which case you can remove everything in between init and clean.
There was a problem hiding this comment.
If I don't commit the files they will be considered as untracked files - hence the commit
There was a problem hiding this comment.
It's true that they will be considered as untracked files, however, that does not affect how clean behaves. See for yourself, try it out.
There was a problem hiding this comment.
I'm also surprised that it works, mind you, so I looked into it. The -X flag for clean is the reason it works: https://git-scm.com/docs/git-clean
airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/format/format_command.py
Outdated
Show resolved
Hide resolved
airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/format/format_command.py
Show resolved
Hide resolved
postamar
reviewed
Dec 12, 2023
Comment on lines
102
to
108
| # This is needed to avoid git complaining about the user not being set | ||
| .with_exec(["config", "user.email", "ci@airbyte.io"]) | ||
| .with_exec(["config", "user.name", "Airbyte CI"]) | ||
| # Add all files to the git index | ||
| .with_exec(["add", "."]) | ||
| # Commit all files | ||
| .with_exec(["commit", "--message", "Commit for formatting"]) |
There was a problem hiding this comment.
Suggested change
| # This is needed to avoid git complaining about the user not being set | |
| .with_exec(["config", "user.email", "ci@airbyte.io"]) | |
| .with_exec(["config", "user.name", "Airbyte CI"]) | |
| # Add all files to the git index | |
| .with_exec(["add", "."]) | |
| # Commit all files | |
| .with_exec(["commit", "--message", "Commit for formatting"]) |
| # Commit all files | ||
| .with_exec(["commit", "--message", "Commit for formatting"]) | ||
| # Remove all gitignored files | ||
| .with_exec(["clean", "-dfX"]) |
There was a problem hiding this comment.
Suggested change
| .with_exec(["clean", "-dfX"]) | |
| .with_exec(["clean", "-dfqX"]) |
The -q option makes for less noise in stdout, apparently.
postamar
approved these changes
Dec 12, 2023
Co-authored-by: Marius Posta <marius@airbyte.io>
alafanechere
force-pushed
the
augustin/12-08-airbyte-ci_format_exlcude_.gitignored_files_from_format
branch
from
65b84fc
to
823514c
Compare
alafanechere
deleted the
augustin/12-08-airbyte-ci_format_exlcude_.gitignored_files_from_format
branch
tmathew0309
pushed a commit
to tmathew0309/airbyte
that referenced
this pull request
Jan 12, 2024
…3249) Co-authored-by: Marius Posta <marius@airbyte.io>
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
…3249) Co-authored-by: Marius Posta <marius@airbyte.io>
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
…3249) Co-authored-by: Marius Posta <marius@airbyte.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Under current implementation
airbyte-ci format check/fixcan format gitignored files.So far we've maintained an exclusion rule in
DEFAULT_FORMAT_IGNORE_LISTbut we don't want to maintain it to match all are git ignore rules.How
git status --ignored --shortDEFAULT_FORMAT_IGNORE_LIST+ this list from the files to format.🚨 User Impact 🚨
Unfortunately
git status --ignoredis pretty slow (~20s on my laptop) so it'll make the format commands 20s slower...