Repository navigation
Destinations bigquery+snowflake+s3: Chore: upgrade CDK version - #33263
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Octavia Squidington III (octavia-squidington-iii)
added
area/connectors
Contributor
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
|
|
||
| @Override | ||
| protected JdbcSqlGenerator getSqlGenerator() { | ||
| throw new UnsupportedOperationException("Snowflake does not yet use the native JDBC DV2 interface"); |
Contributor
Author
There was a problem hiding this comment.
we probably should do this eventually, but not a high priority imo
| } | ||
|
|
||
| @Override | ||
| protected void insertRecordsInternalV2(final JdbcDatabase jdbcDatabase, final List<PartialAirbyteMessage> list, final String s, final String s1) throws Exception { |
Contributor
Author
There was a problem hiding this comment.
I'm not sure we ever want to do this? Since snowflake only has an internal staging loading method, i.e. standard inserts doesn't exist at all
Contributor
There was a problem hiding this comment.
So the insertRecordsInternal is also dead code path ?
Contributor
Author
Gireesh Sreepathi (gisripa)
approved these changes
Dec 8, 2023
Edward Gao (edgao)
enabled auto-merge (squash)
December 8, 2023 19:56
Octavia Squidington III (octavia-squidington-iii)
added
the
area/documentation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in #32326 we made some breaking changes to the java destination cdk. Upgrade the cdk version in bigquery+snowflake+s3 and fix their respective builds.
(only snowflake actually needed code changes)
I originally had these as part of #33232, figured it's probably better to merge this stuff separately.