Source Salesforce: process streams concurrently on full refresh - #33350
Merged
Catherine Noll (clnoll) merged 2 commits intoDec 13, 2023
Conversation
Catherine Noll (clnoll)
marked this pull request as draft
December 12, 2023 15:00
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
Octavia Squidington IV (octavia-squidington-iv)
requested a review
from a team
December 12, 2023 15:01
Catherine Noll (clnoll)
force-pushed
the
source-salesforce-concurrent-streams
branch
from
December 12, 2023 15:01
daf9986 to
1898882
Compare
Catherine Noll (clnoll)
force-pushed
the
source-salesforce-concurrent-streams
branch
from
December 12, 2023 15:04
1898882 to
96d38ee
Compare
Catherine Noll (clnoll)
marked this pull request as ready for review
December 12, 2023 15:11
Catherine Noll (clnoll)
requested review from
Alexandre Girard (girarda) and
Maxime Carbonneau-Leclerc (maxi297)
December 12, 2023 15:11
Catherine Noll (clnoll)
force-pushed
the
source-salesforce-concurrent-streams
branch
from
December 12, 2023 17:00
96d38ee to
77b7200
Compare
Alexandre Girard (girarda)
approved these changes
Dec 13, 2023
Alexandre Girard (girarda)
left a comment
Collaborator
There was a problem hiding this comment.
lgtm! 🚢
Maxime Carbonneau-Leclerc (maxi297)
approved these changes
Dec 13, 2023
Maxime Carbonneau-Leclerc (maxi297)
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
Catherine Noll (clnoll)
deleted the
source-salesforce-concurrent-streams
branch
December 13, 2023 21:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the source-salesforce connector to use the new ConcurrentSourceAdapter, which allows it to sync streams concurrently.
This is only enabled for full refresh syncs.